diff options
| author | Nick Mathewson <nickm@torproject.org> | 2017-07-05 13:42:26 -0400 |
|---|---|---|
| committer | Nick Mathewson <nickm@torproject.org> | 2017-07-05 13:42:26 -0400 |
| commit | ff8c230d7cadb6c24dcf9c121521cff976fc83a5 (patch) | |
| tree | fe76df5da20a4c5292a4ef4588596867e3e0f045 | |
| parent | ccae991662adb3b64bdb1dcd4a942e4d1e163414 (diff) | |
| parent | 0ee15c92d5486fc73ba49dea7f12bf2f89012cfb (diff) | |
| download | tor-ff8c230d7cadb6c24dcf9c121521cff976fc83a5.tar.gz tor-ff8c230d7cadb6c24dcf9c121521cff976fc83a5.zip | |
Merge branch 'maint-0.2.4' into maint-0.2.5
| -rw-r--r-- | changes/bug22789 | 6 | ||||
| -rw-r--r-- | src/common/compat.c | 8 | ||||
| -rw-r--r-- | src/test/test_addr.c | 9 |
3 files changed, 21 insertions, 2 deletions
diff --git a/changes/bug22789 b/changes/bug22789 new file mode 100644 index 0000000000..dc9fa29811 --- /dev/null +++ b/changes/bug22789 @@ -0,0 +1,6 @@ + o Major bugfixes (openbsd, denial-of-service): + - Avoid an assertion failure bug affecting our implementation of + inet_pton(AF_INET6) on certain OpenBSD systems whose strtol() + handling of "0xfoo" differs from what we had expected. + Fixes bug 22789; bugfix on 0.2.3.8-alpha. + diff --git a/src/common/compat.c b/src/common/compat.c index e25ecc462d..53d0623c84 100644 --- a/src/common/compat.c +++ b/src/common/compat.c @@ -2332,8 +2332,12 @@ tor_inet_pton(int af, const char *src, void *dst) char *next; ssize_t len; long r = strtol(src, &next, 16); - tor_assert(next != NULL); - tor_assert(next != src); + if (next == NULL || next == src) { + /* The 'next == src' error case can happen on versions of openbsd + * where treats "0xfoo" as an error, rather than as "0" followed by + * "xfoo". */ + return 0; + } len = *next == '\0' ? eow - src : next - src; if (len > 4) diff --git a/src/test/test_addr.c b/src/test/test_addr.c index 50011e606b..2c126e6d14 100644 --- a/src/test/test_addr.c +++ b/src/test/test_addr.c @@ -349,6 +349,15 @@ test_addr_ip6_helpers(void) test_pton6_bad("1.2.3.4"); test_pton6_bad(":1.2.3.4"); test_pton6_bad(".2.3.4"); + /* Regression tests for 22789. */ + test_pton6_bad("0xfoo"); + test_pton6_bad("0x88"); + test_pton6_bad("0xyxxy"); + test_pton6_bad("0XFOO"); + test_pton6_bad("0X88"); + test_pton6_bad("0XYXXY"); + test_pton6_bad("0x"); + test_pton6_bad("0X"); /* test internal checking */ test_external_ip("fbff:ffff::2:7", 0); |