diff options
| author | Nick Mathewson <nickm@torproject.org> | 2017-02-07 08:37:07 -0500 |
|---|---|---|
| committer | Nick Mathewson <nickm@torproject.org> | 2017-02-07 08:37:07 -0500 |
| commit | 51675f97d30e48da68f2cf538f7f805f51af4c36 (patch) | |
| tree | 532b01ec0e1e720fbf82aa3f8b99803d2e45a218 | |
| parent | 6cb8c0fd4e9c544710b1ad72a695feb87a1d7ee7 (diff) | |
| parent | 9459ae260e3ae428283c3b45d08aaef6ef9f6fa3 (diff) | |
| download | tor-51675f97d30e48da68f2cf538f7f805f51af4c36.tar.gz tor-51675f97d30e48da68f2cf538f7f805f51af4c36.zip | |
Merge remote-tracking branch 'public/bug17404_024' into maint-0.2.4
| -rw-r--r-- | changes/bug17404 | 6 | ||||
| -rw-r--r-- | src/common/tortls.c | 4 |
2 files changed, 10 insertions, 0 deletions
diff --git a/changes/bug17404 b/changes/bug17404 new file mode 100644 index 0000000000..d524f6662d --- /dev/null +++ b/changes/bug17404 @@ -0,0 +1,6 @@ + o Major bugfixes (security, correctness): + - Fix a programming error that could cause us to read 4 bytes before + the beginning of an openssl string. This could be used to provoke + a crash on systems with an unusual malloc implementation, or + systems with unsual hardening installed. Fixes bug 17404; bugfix + on 0.2.3.6-alpha. diff --git a/src/common/tortls.c b/src/common/tortls.c index 4222f6dbff..840b677cb7 100644 --- a/src/common/tortls.c +++ b/src/common/tortls.c @@ -2676,6 +2676,10 @@ dn_indicates_v3_cert(X509_NAME *name) len = ASN1_STRING_to_UTF8(&s, str); if (len < 0) return 0; + if (len < 4) { + OPENSSL_free(s); + return 1; + } r = fast_memneq(s + len - 4, ".net", 4); OPENSSL_free(s); return r; |