diff options
| author | Nick Mathewson <nickm@torproject.org> | 2017-07-05 13:43:31 -0400 |
|---|---|---|
| committer | Nick Mathewson <nickm@torproject.org> | 2017-07-05 13:43:31 -0400 |
| commit | 332c637f241d5253df34e6fb09f5a5c6bb2574d0 (patch) | |
| tree | 2012d8cac4e03b82c6f7541f337d8a42ac839e1f | |
| parent | 1fd9d5ef37943a3c4688b113972bb7f6d44dbb7f (diff) | |
| parent | f6420bceec9707324fe23c98a2a70dd2612f183f (diff) | |
| download | tor-332c637f241d5253df34e6fb09f5a5c6bb2574d0.tar.gz tor-332c637f241d5253df34e6fb09f5a5c6bb2574d0.zip | |
Merge branch 'maint-0.2.6' into release-0.2.6
| -rw-r--r-- | changes/bug22789 | 6 | ||||
| -rw-r--r-- | src/common/compat.c | 8 | ||||
| -rw-r--r-- | src/test/test_addr.c | 9 |
3 files changed, 21 insertions, 2 deletions
diff --git a/changes/bug22789 b/changes/bug22789 new file mode 100644 index 0000000000..dc9fa29811 --- /dev/null +++ b/changes/bug22789 @@ -0,0 +1,6 @@ + o Major bugfixes (openbsd, denial-of-service): + - Avoid an assertion failure bug affecting our implementation of + inet_pton(AF_INET6) on certain OpenBSD systems whose strtol() + handling of "0xfoo" differs from what we had expected. + Fixes bug 22789; bugfix on 0.2.3.8-alpha. + diff --git a/src/common/compat.c b/src/common/compat.c index 1788e32ee3..6b9f1f71f2 100644 --- a/src/common/compat.c +++ b/src/common/compat.c @@ -2370,8 +2370,12 @@ tor_inet_pton(int af, const char *src, void *dst) char *next; ssize_t len; long r = strtol(src, &next, 16); - tor_assert(next != NULL); - tor_assert(next != src); + if (next == NULL || next == src) { + /* The 'next == src' error case can happen on versions of openbsd + * where treats "0xfoo" as an error, rather than as "0" followed by + * "xfoo". */ + return 0; + } len = *next == '\0' ? eow - src : next - src; if (len > 4) diff --git a/src/test/test_addr.c b/src/test/test_addr.c index 2c25c1ef7d..0f77e73630 100644 --- a/src/test/test_addr.c +++ b/src/test/test_addr.c @@ -353,6 +353,15 @@ test_addr_ip6_helpers(void *arg) test_pton6_bad("1.2.3.4"); test_pton6_bad(":1.2.3.4"); test_pton6_bad(".2.3.4"); + /* Regression tests for 22789. */ + test_pton6_bad("0xfoo"); + test_pton6_bad("0x88"); + test_pton6_bad("0xyxxy"); + test_pton6_bad("0XFOO"); + test_pton6_bad("0X88"); + test_pton6_bad("0XYXXY"); + test_pton6_bad("0x"); + test_pton6_bad("0X"); /* test internal checking */ test_external_ip("fbff:ffff::2:7", 0); |