aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDavid Goulet <dgoulet@torproject.org>2024-08-05 11:59:30 -0400
committerDavid Goulet <dgoulet@torproject.org>2024-08-05 11:59:30 -0400
commit93df26b11a67423e05c200cd93cba6398b9f2a49 (patch)
tree16c74b414cfb9d5468266b97556bcced38f2cf05
parentd587ba01a70b81e8c15f6e53e72c133ebe977719 (diff)
downloadtor-93df26b11a67423e05c200cd93cba6398b9f2a49.tar.gz
tor-93df26b11a67423e05c200cd93cba6398b9f2a49.zip
dirvote: Fix memleak when computing consensus
Fixes #40966 Signed-off-by: David Goulet <dgoulet@torproject.org>
-rw-r--r--changes/ticket409663
-rw-r--r--src/feature/dirauth/dirvote.c4
2 files changed, 6 insertions, 1 deletions
diff --git a/changes/ticket40966 b/changes/ticket40966
new file mode 100644
index 0000000000..04fb3caded
--- /dev/null
+++ b/changes/ticket40966
@@ -0,0 +1,3 @@
+ o Minor bugfixes (memleak, authority):
+ - Fix a small memleak when computing a new consensus. This only affects
+ directory authorities. Fixes bug 40966; bugfix on 0.3.5.1-alpha.
diff --git a/src/feature/dirauth/dirvote.c b/src/feature/dirauth/dirvote.c
index 1080415827..0783fb1e91 100644
--- a/src/feature/dirauth/dirvote.c
+++ b/src/feature/dirauth/dirvote.c
@@ -3543,8 +3543,10 @@ dirvote_compute_consensuses(void)
{
char *filename;
tor_asprintf(&filename, "my-consensus-%s", flavor_name);
- write_str_to_file(get_datadir_fname(filename), consensus_body, 0);
+ char *fpath = get_datadir_fname(filename);
+ write_str_to_file(fpath, consensus_body, 0);
tor_free(filename);
+ tor_free(fpath);
}
consensus_body = NULL;