aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorNick Mathewson <nickm@torproject.org>2018-04-09 12:58:17 -0400
committerNick Mathewson <nickm@torproject.org>2018-04-09 12:58:17 -0400
commite58555135a11e1c78b130cb4807d5dc1d1dfe97b (patch)
tree23026a13cbd0dd515fd65ae701f63e4d2047fa29
parent2fac948158f50ed062a059def81da632b1d8ce18 (diff)
downloadtor-e58555135a11e1c78b130cb4807d5dc1d1dfe97b.tar.gz
tor-e58555135a11e1c78b130cb4807d5dc1d1dfe97b.zip
Add a comment explaining why we do a certain redundant check
Closes ticket 25291.
-rw-r--r--src/or/config.c5
1 files changed, 5 insertions, 0 deletions
diff --git a/src/or/config.c b/src/or/config.c
index 8658a13269..3c3fd46e6f 100644
--- a/src/or/config.c
+++ b/src/or/config.c
@@ -2269,6 +2269,11 @@ options_act(const or_options_t *old_options)
}
if ((!old_options || !old_options->EntryStatistics) &&
options->EntryStatistics && !should_record_bridge_info(options)) {
+ /* If we get here, we've started recording bridge info when we didn't
+ * do so before. Note that "should_record_bridge_info()" will
+ * always be false at this point, because of the earlier block
+ * that cleared EntryStatistics when public_server_mode() was false.
+ * We're leaving it in as defensive programming. */
if (geoip_is_loaded(AF_INET) || geoip_is_loaded(AF_INET6)) {
geoip_entry_stats_init(now);
print_notice = 1;