aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorNick Mathewson <nickm@torproject.org>2019-01-03 09:44:10 -0500
committerNick Mathewson <nickm@torproject.org>2019-01-03 09:44:10 -0500
commit98736cf36a1d8250e53a0c86a0b80fdb75f0d551 (patch)
tree7ee43e7e7bec0e13b16ecb1f9499b6fcca0d1514
parented62f0fa151f7a21a9634fbec1e95832ddbede94 (diff)
parent041e9235c1710936a43f73d2f6e87bfc6e1c2242 (diff)
downloadtor-98736cf36a1d8250e53a0c86a0b80fdb75f0d551.tar.gz
tor-98736cf36a1d8250e53a0c86a0b80fdb75f0d551.zip
Merge remote-tracking branch 'public/ticket28838_035' into maint-0.3.5
-rw-r--r--changes/ticket288388
-rw-r--r--src/lib/crypt_ops/crypto_curve25519.c2
2 files changed, 9 insertions, 1 deletions
diff --git a/changes/ticket28838 b/changes/ticket28838
new file mode 100644
index 0000000000..6c290bf82b
--- /dev/null
+++ b/changes/ticket28838
@@ -0,0 +1,8 @@
+ o Minor features (performance):
+ - Remove about 96% of the work from the function that we run at
+ startup to test our curve25519_basepoint implementation. Since
+ this function has yet to find an actual failure, we'll only
+ run it for 8 iterations instead of 200. Based on our profile
+ information, this change should save around 8% of our startup
+ time on typical desktops, and may have a similar effect on
+ other platforms. Closes ticket 28838.
diff --git a/src/lib/crypt_ops/crypto_curve25519.c b/src/lib/crypt_ops/crypto_curve25519.c
index e6a39a8c08..f3a9de9fc5 100644
--- a/src/lib/crypt_ops/crypto_curve25519.c
+++ b/src/lib/crypt_ops/crypto_curve25519.c
@@ -289,7 +289,7 @@ curve25519_basepoint_spot_check(void)
0x0d,0xbf,0x3a,0x0d,0x26,0x38,0x1a,0xf4,
0xeb,0xa4,0xa9,0x8e,0xaa,0x9b,0x4e,0x6a
};
- const int loop_max=200;
+ const int loop_max=8;
int save_use_ed = curve25519_use_ed;
unsigned char e1[32], e2[32];
unsigned char x[32],y[32];