diff options
| author | Nick Mathewson <nickm@torproject.org> | 2020-07-07 14:58:49 -0400 |
|---|---|---|
| committer | Nick Mathewson <nickm@torproject.org> | 2020-07-07 15:05:38 -0400 |
| commit | 3e08dd9df1142b66e5f53a55d7e4c2803c3f9868 (patch) | |
| tree | 5c57f48984c496242293a7ae8f4b7c5b378c5831 | |
| parent | d9cc2b2928eab045f89d0abf95a9e5c75e290ff8 (diff) | |
| download | tor-3e08dd9df1142b66e5f53a55d7e4c2803c3f9868.tar.gz tor-3e08dd9df1142b66e5f53a55d7e4c2803c3f9868.zip | |
Resolve a compiler warning from a 32-bit signed/unsigned comparison
This warning only affects platforms (like win32) with 32-bit time_t.
Fixes bug 40028; bugfix on 0.3.2.8-rc.
| -rw-r--r-- | changes/bug40028 | 3 | ||||
| -rw-r--r-- | src/lib/tls/x509.c | 3 |
2 files changed, 5 insertions, 1 deletions
diff --git a/changes/bug40028 b/changes/bug40028 new file mode 100644 index 0000000000..cfd1ffe516 --- /dev/null +++ b/changes/bug40028 @@ -0,0 +1,3 @@ + o Minor bugfixes (compiler warnings): + - Fix a compiler warning on platforms with 32-bit time_t values. + Fixes bug 40028; bugfix on 0.3.2.8-rc. diff --git a/src/lib/tls/x509.c b/src/lib/tls/x509.c index 67a8b49b9d..b4a0f8dabf 100644 --- a/src/lib/tls/x509.c +++ b/src/lib/tls/x509.c @@ -23,6 +23,7 @@ tor_tls_pick_certificate_lifetime(time_t now, time_t *start_time_out, time_t *end_time_out) { + tor_assert(cert_lifetime < INT_MAX); time_t start_time, end_time; /* Make sure we're part-way through the certificate lifetime, rather * than having it start right now. Don't choose quite uniformly, since @@ -36,7 +37,7 @@ tor_tls_pick_certificate_lifetime(time_t now, const time_t start_granularity = 24*3600; time_t earliest_start_time; /* Don't actually start in the future! */ - if (cert_lifetime <= min_real_lifetime + start_granularity) { + if ((int)cert_lifetime <= min_real_lifetime + start_granularity) { earliest_start_time = now - 1; } else { earliest_start_time = now + min_real_lifetime + start_granularity |