diff options
| author | Nick Mathewson <nickm@torproject.org> | 2020-05-06 10:35:36 -0400 |
|---|---|---|
| committer | Nick Mathewson <nickm@torproject.org> | 2020-05-06 15:08:02 -0400 |
| commit | 9fe23b8672fdc4da64a99acf55b47193375b9562 (patch) | |
| tree | 540743343adfcc4a99ed6e6d2a957ab27223976d | |
| parent | 75547c01a37c65398f8d31ee9cb38d865119cd28 (diff) | |
| download | tor-9fe23b8672fdc4da64a99acf55b47193375b9562.tar.gz tor-9fe23b8672fdc4da64a99acf55b47193375b9562.zip | |
Replace some "fall through" comments not at the end of a case.
| -rw-r--r-- | src/core/proto/proto_socks.c | 5 | ||||
| -rw-r--r-- | src/feature/relay/dns.c | 2 |
2 files changed, 5 insertions, 2 deletions
diff --git a/src/core/proto/proto_socks.c b/src/core/proto/proto_socks.c index 8b78ed44c2..a6493366e6 100644 --- a/src/core/proto/proto_socks.c +++ b/src/core/proto/proto_socks.c @@ -1067,7 +1067,10 @@ parse_socks_client(const uint8_t *data, size_t datalen, log_info(LD_NET, "SOCKS 5 client: need authentication."); *drain_out = -1; return 2; - /* fall through */ + default: + /* This wasn't supposed to be exhaustive; there are other + * authentication methods too. */ + ; } *reason = tor_strdup("server doesn't support any of our available " diff --git a/src/feature/relay/dns.c b/src/feature/relay/dns.c index cc9f4cf490..38395862c3 100644 --- a/src/feature/relay/dns.c +++ b/src/feature/relay/dns.c @@ -546,7 +546,7 @@ send_resolved_cell,(edge_connection_t *conn, uint8_t answer_type, break; } else { answer_type = RESOLVED_TYPE_ERROR; - /* fall through. */ + /* We let this fall through and treat it as an error. */ } /* Falls through. */ case RESOLVED_TYPE_ERROR_TRANSIENT: |