aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDavid Goulet <dgoulet@torproject.org>2018-02-05 10:52:17 -0500
committerDavid Goulet <dgoulet@torproject.org>2018-02-05 13:46:43 -0500
commit7ce8d5513ba388259e4e251d49183ef0fe9c8fa8 (patch)
treedb09482435a18da705acc73ff3bc7c3da201e4fa
parenta2aaf9509ba578f4e7705b506ee9a0f764d24ff2 (diff)
downloadtor-7ce8d5513ba388259e4e251d49183ef0fe9c8fa8.tar.gz
tor-7ce8d5513ba388259e4e251d49183ef0fe9c8fa8.zip
Make circuit_log_ancient_one_hop_circuits() ignore established service rendezvous
Services can keep rendezvous circuits for a while so don't log them if tor is a single onion service. Fixes #25116 Signed-off-by: David Goulet <dgoulet@torproject.org>
-rw-r--r--changes/bug251164
-rw-r--r--src/or/circuituse.c6
2 files changed, 7 insertions, 3 deletions
diff --git a/changes/bug25116 b/changes/bug25116
new file mode 100644
index 0000000000..b3e73feeaa
--- /dev/null
+++ b/changes/bug25116
@@ -0,0 +1,4 @@
+ o Minor bugfixes (hidden service, heartbeat):
+ - Don't log in the heartbeat any long term established one hop rendezvous
+ points if tor is a single onion service. Fixes bug 25116; bugfix on
+ 0.2.9.6-rc;
diff --git a/src/or/circuituse.c b/src/or/circuituse.c
index 84574cd5b9..96cd3cd7e8 100644
--- a/src/or/circuituse.c
+++ b/src/or/circuituse.c
@@ -808,10 +808,10 @@ circuit_log_ancient_one_hop_circuits(int age)
if (circ->timestamp_created.tv_sec >= cutoff)
continue;
/* Single Onion Services deliberately make long term one-hop intro
- * connections. We only ignore active intro point connections, if we take
- * a long time establishing, that's worth logging. */
+ * and rendezvous connections. Don't log the established ones. */
if (rend_service_allow_non_anonymous_connection(options) &&
- circ->purpose == CIRCUIT_PURPOSE_S_INTRO)
+ (circ->purpose == CIRCUIT_PURPOSE_S_INTRO ||
+ circ->purpose == CIRCUIT_PURPOSE_S_REND_JOINED))
continue;
/* Tor2web deliberately makes long term one-hop rend connections,
* particularly when Tor2webRendezvousPoints is used. We only ignore