diff options
| author | Nick Mathewson <nickm@torproject.org> | 2011-10-06 12:57:07 -0400 |
|---|---|---|
| committer | Nick Mathewson <nickm@torproject.org> | 2011-10-26 13:22:20 -0400 |
| commit | b1632c3fb742f94a6ce0de201653a8c4a9d2887f (patch) | |
| tree | fa680b2dafddec3af667daa4953afabb2d1d8810 | |
| parent | 097ed9998bc93b2dff1c6dcbff974ab4d8d17731 (diff) | |
| download | tor-b1632c3fb742f94a6ce0de201653a8c4a9d2887f.tar.gz tor-b1632c3fb742f94a6ce0de201653a8c4a9d2887f.zip | |
Fix memory leak in retry_all_listeners: Coverity CID 485
| -rw-r--r-- | src/or/connection.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/or/connection.c b/src/or/connection.c index af0572905d..bf39a5cb9c 100644 --- a/src/or/connection.c +++ b/src/or/connection.c @@ -1988,13 +1988,13 @@ retry_all_listeners(smartlist_t *replaced_conns, options->ControlListenAddress, options->ControlPort, "127.0.0.1", new_conns, 0) < 0) - return -1; + retval = -1; if (retry_listeners(listeners, CONN_TYPE_CONTROL_LISTENER, options->ControlSocket, options->ControlSocket ? 1 : 0, NULL, new_conns, 1) < 0) - return -1; + retval = -1; /* Any members that were still in 'listeners' don't correspond to * any configured port. Kill 'em. */ |