aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorNick Mathewson <nickm@torproject.org>2014-08-21 11:05:59 -0400
committerNick Mathewson <nickm@torproject.org>2014-08-21 11:22:42 -0400
commita66fff6381abc5e3a70bd9cf3108560ed79f8d3e (patch)
treeaac54a2e94aade1f0dea64e4ec00619dec15598d
parent059e33de59030b008193512b58a51be922fffea4 (diff)
downloadtor-a66fff6381abc5e3a70bd9cf3108560ed79f8d3e.tar.gz
tor-a66fff6381abc5e3a70bd9cf3108560ed79f8d3e.zip
Mark one use of networkstatus_check_document_signature as (void)
Also explain why we aren't checking its return value. [CID 1198197]
-rw-r--r--src/or/dirvote.c7
1 files changed, 5 insertions, 2 deletions
diff --git a/src/or/dirvote.c b/src/or/dirvote.c
index 6536b7fe99..cf6b88eb31 100644
--- a/src/or/dirvote.c
+++ b/src/or/dirvote.c
@@ -2273,8 +2273,11 @@ networkstatus_add_detached_signatures(networkstatus_t *target,
if (!sig->good_signature && !sig->bad_signature) {
cert = authority_cert_get_by_digests(sig->identity_digest,
sig->signing_key_digest);
- if (cert)
- networkstatus_check_document_signature(target, sig, cert);
+ if (cert) {
+ /* Not checking the return value here, since we are going to look
+ * at the status of sig->good_signature in a moment. */
+ (void) networkstatus_check_document_signature(target, sig, cert);
+ }
}
/* If this signature is good, or we don't have any signature yet,