diff options
| author | Nick Mathewson <nickm@torproject.org> | 2015-12-08 09:37:05 -0500 |
|---|---|---|
| committer | Nick Mathewson <nickm@torproject.org> | 2015-12-08 09:37:05 -0500 |
| commit | b0867fec964a8692e9c605da82b3a3393eeaf451 (patch) | |
| tree | 0ffd3c1bb6c9563720362b29b16a83cdfd10c313 | |
| parent | dbb919cf9400738987bbb91166b7b30c4cf770e9 (diff) | |
| download | tor-b0867fec964a8692e9c605da82b3a3393eeaf451.tar.gz tor-b0867fec964a8692e9c605da82b3a3393eeaf451.zip | |
Fix a compilation warning introduced by clang 3.6
There was a dead check when we made sure that an array member of a
struct was non-NULL. Tor has been doing this check since at least
0.2.3, maybe earlier.
Fixes bug 17781.
| -rw-r--r-- | changes/bug17781 | 3 | ||||
| -rw-r--r-- | src/or/connection_edge.c | 2 |
2 files changed, 4 insertions, 1 deletions
diff --git a/changes/bug17781 b/changes/bug17781 new file mode 100644 index 0000000000..01ed231b0a --- /dev/null +++ b/changes/bug17781 @@ -0,0 +1,3 @@ + o Compilation fixes: + - Fix a compilation warning with Clang 3.6: Do not check the + presence of an address which can never be NULL. Fixes bug 17781. diff --git a/src/or/connection_edge.c b/src/or/connection_edge.c index 895c0f7f01..39f8af61f6 100644 --- a/src/or/connection_edge.c +++ b/src/or/connection_edge.c @@ -748,7 +748,7 @@ connection_ap_fail_onehop(const char *failed_digest, /* we don't know the digest; have to compare addr:port */ tor_addr_t addr; if (!build_state || !build_state->chosen_exit || - !entry_conn->socks_request || !entry_conn->socks_request->address) + !entry_conn->socks_request) continue; if (tor_addr_parse(&addr, entry_conn->socks_request->address)<0 || !tor_addr_eq(&build_state->chosen_exit->addr, &addr) || |