diff options
| author | Markus Heiser <markus.heiser@darmarit.de> | 2022-04-01 10:27:41 +0200 |
|---|---|---|
| committer | Markus Heiser <markus.heiser@darmarit.de> | 2022-04-01 10:34:21 +0200 |
| commit | 6c747c40c10ee3259e8ef48b2d701a0c8f96a47d (patch) | |
| tree | 482145697567abe81681647c4b6242e13816f86e /tests | |
| parent | fd67df7d7c7a8efee42015119593b29a42f31ec3 (diff) | |
| download | searxng-6c747c40c10ee3259e8ef48b2d701a0c8f96a47d.tar.gz searxng-6c747c40c10ee3259e8ef48b2d701a0c8f96a47d.zip | |
[fix] issue when upgrading from werkzeug v2.0.3 to v2.1.0
In v2.1.0 werkzeug [1] fixed an issue [2] to keep relative redirect locations by
default [3]. Since relative locations are returned, we need to fix out test
cases to avoid AssertionErrors like this one::
======================================================================
FAIL: test_index_html_get (tests.unit.test_webapp.ViewsTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/home/runner/work/searxng/searxng/tests/unit/test_webapp.py", line 105, in test_index_html_get
self.assertEqual(result.location, 'http://localhost/search?q=test')
AssertionError: '/search?q=test' != 'http://localhost/search?q=test'
- /search?q=test
+ http://localhost/search?q=test
[1] https://werkzeug.palletsprojects.com/
[2] https://github.com/pallets/werkzeug/issues/2352 fixed in
[3] https://github.com/pallets/werkzeug/pull/2354
Related-to: https://github.com/searxng/searxng/pull/1039#issuecomment-1085538288
Signed-off-by: Markus Heiser <markus.heiser@darmarit.de>
Diffstat (limited to 'tests')
| -rw-r--r-- | tests/unit/test_webapp.py | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/tests/unit/test_webapp.py b/tests/unit/test_webapp.py index d3eaa6a58..bb09e591e 100644 --- a/tests/unit/test_webapp.py +++ b/tests/unit/test_webapp.py @@ -97,12 +97,12 @@ class ViewsTestCase(SearxTestCase): def test_index_html_post(self): result = self.app.post('/', data={'q': 'test'}) self.assertEqual(result.status_code, 308) - self.assertEqual(result.location, 'http://localhost/search') + self.assertEqual(result.location, '/search') def test_index_html_get(self): result = self.app.post('/?q=test') self.assertEqual(result.status_code, 308) - self.assertEqual(result.location, 'http://localhost/search?q=test') + self.assertEqual(result.location, '/search?q=test') def test_search_empty_html(self): result = self.app.post('/search', data={'q': ''}) |