diff options
author | Markus Heiser <markus.heiser@darmarit.de> | 2021-09-17 10:14:27 +0200 |
---|---|---|
committer | Markus Heiser <markus.heiser@darmarit.de> | 2021-09-17 10:14:27 +0200 |
commit | 443bf35e09ce27d07c18c01d455886e85ead53f9 (patch) | |
tree | 1c8b9fbc638f0e0317deac0d76347b275abd78e3 /searx/network | |
parent | fe6470cbe6f5072cbfa2adc6c08790ed49510bde (diff) | |
download | searxng-443bf35e09ce27d07c18c01d455886e85ead53f9.tar.gz searxng-443bf35e09ce27d07c18c01d455886e85ead53f9.zip |
[pylint] fix global-variable-not-assigned issues
If there is no write access, there is no need for global. Remove global
statement if there is no assignment.
global-variable-not-assigned:
Using global for names but no assignment is done Used when a variable is
defined through the "global" statement but no assignment to this variable is
done.
In Pylint 2.11 the global-variable-not-assigned checker now catches global
variables that are never reassigned in a local scope and catches (reassigned)
functions [1][2]
[1] https://pylint.pycqa.org/en/latest/whatsnew/2.11.html
[2] https://github.com/PyCQA/pylint/issues/1375
Signed-off-by: Markus Heiser <markus.heiser@darmarit.de>
Diffstat (limited to 'searx/network')
-rw-r--r-- | searx/network/__init__.py | 6 | ||||
-rw-r--r-- | searx/network/client.py | 4 | ||||
-rw-r--r-- | searx/network/network.py | 5 |
3 files changed, 0 insertions, 15 deletions
diff --git a/searx/network/__init__.py b/searx/network/__init__.py index 21c4c27b5..bcc0b690a 100644 --- a/searx/network/__init__.py +++ b/searx/network/__init__.py @@ -43,24 +43,20 @@ THREADLOCAL = threading.local() """Thread-local data is data for thread specific values.""" def reset_time_for_thread(): - global THREADLOCAL THREADLOCAL.total_time = 0 def get_time_for_thread(): """returns thread's total time or None""" - global THREADLOCAL return THREADLOCAL.__dict__.get('total_time') def set_timeout_for_thread(timeout, start_time=None): - global THREADLOCAL THREADLOCAL.timeout = timeout THREADLOCAL.start_time = start_time def set_context_network_name(network_name): - global THREADLOCAL THREADLOCAL.network = get_network(network_name) @@ -69,13 +65,11 @@ def get_context_network(): If unset, return value from :py:obj:`get_network`. """ - global THREADLOCAL return THREADLOCAL.__dict__.get('network') or get_network() def request(method, url, **kwargs): """same as requests/requests/api.py request(...)""" - global THREADLOCAL time_before_request = default_timer() # timeout (httpx) diff --git a/searx/network/client.py b/searx/network/client.py index e1abff05a..5e889b2b0 100644 --- a/searx/network/client.py +++ b/searx/network/client.py @@ -53,7 +53,6 @@ async def close_connections_for_url( def get_sslcontexts(proxy_url=None, cert=None, verify=True, trust_env=True, http2=False): - global SSLCONTEXTS key = (proxy_url, cert, verify, trust_env, http2) if key not in SSLCONTEXTS: SSLCONTEXTS[key] = httpx.create_ssl_context(cert, verify, trust_env, http2) @@ -137,7 +136,6 @@ class AsyncHTTPTransportFixed(httpx.AsyncHTTPTransport): def get_transport_for_socks_proxy(verify, http2, local_address, proxy_url, limit, retries): - global TRANSPORT_KWARGS # support socks5h (requests compatibility): # https://requests.readthedocs.io/en/master/user/advanced/#socks # socks5:// hostname is resolved on client side @@ -167,7 +165,6 @@ def get_transport_for_socks_proxy(verify, http2, local_address, proxy_url, limit def get_transport(verify, http2, local_address, proxy_url, limit, retries): - global TRANSPORT_KWARGS verify = get_sslcontexts(None, None, True, False, http2) if verify is True else verify return AsyncHTTPTransportFixed( # pylint: disable=protected-access @@ -235,7 +232,6 @@ def new_client( def get_loop(): - global LOOP return LOOP diff --git a/searx/network/network.py b/searx/network/network.py index 9954f0507..cd6025dfc 100644 --- a/searx/network/network.py +++ b/searx/network/network.py @@ -225,12 +225,10 @@ class Network: @classmethod async def aclose_all(cls): - global NETWORKS await asyncio.gather(*[network.aclose() for network in NETWORKS.values()], return_exceptions=False) def get_network(name=None): - global NETWORKS return NETWORKS.get(name or DEFAULT_NAME) @@ -240,8 +238,6 @@ def initialize(settings_engines=None, settings_outgoing=None): from searx import settings # pylint: enable=import-outside-toplevel) - global NETWORKS - settings_engines = settings_engines or settings['engines'] settings_outgoing = settings_outgoing or settings['outgoing'] @@ -328,7 +324,6 @@ def done(): Note: since Network.aclose has to be async, it is not possible to call this method on Network.__del__ So Network.aclose is called here using atexit.register """ - global NETWORKS try: loop = get_loop() if loop: |