diff options
| author | Markus Heiser <markus.heiser@darmarit.de> | 2021-09-17 10:14:27 +0200 |
|---|---|---|
| committer | Markus Heiser <markus.heiser@darmarit.de> | 2021-09-17 10:14:27 +0200 |
| commit | 443bf35e09ce27d07c18c01d455886e85ead53f9 (patch) | |
| tree | 1c8b9fbc638f0e0317deac0d76347b275abd78e3 /searx/engines | |
| parent | fe6470cbe6f5072cbfa2adc6c08790ed49510bde (diff) | |
| download | searxng-443bf35e09ce27d07c18c01d455886e85ead53f9.tar.gz searxng-443bf35e09ce27d07c18c01d455886e85ead53f9.zip | |
[pylint] fix global-variable-not-assigned issues
If there is no write access, there is no need for global. Remove global
statement if there is no assignment.
global-variable-not-assigned:
Using global for names but no assignment is done Used when a variable is
defined through the "global" statement but no assignment to this variable is
done.
In Pylint 2.11 the global-variable-not-assigned checker now catches global
variables that are never reassigned in a local scope and catches (reassigned)
functions [1][2]
[1] https://pylint.pycqa.org/en/latest/whatsnew/2.11.html
[2] https://github.com/PyCQA/pylint/issues/1375
Signed-off-by: Markus Heiser <markus.heiser@darmarit.de>
Diffstat (limited to 'searx/engines')
| -rw-r--r-- | searx/engines/command.py | 2 | ||||
| -rw-r--r-- | searx/engines/demo_offline.py | 1 | ||||
| -rw-r--r-- | searx/engines/redis_server.py | 4 | ||||
| -rw-r--r-- | searx/engines/sqlite.py | 2 | ||||
| -rw-r--r-- | searx/engines/yggtorrent.py | 1 |
5 files changed, 1 insertions, 9 deletions
diff --git a/searx/engines/command.py b/searx/engines/command.py index 33270d245..aca379c67 100644 --- a/searx/engines/command.py +++ b/searx/engines/command.py @@ -35,7 +35,7 @@ def init(engine_settings): if 'command' not in engine_settings: raise ValueError('engine command : missing configuration key: command') - global command, working_dir, result_template, delimiter, parse_regex, timeout, environment_variables + global command, working_dir, delimiter, parse_regex, environment_variables command = engine_settings['command'] diff --git a/searx/engines/demo_offline.py b/searx/engines/demo_offline.py index 06609d2c3..a4a632180 100644 --- a/searx/engines/demo_offline.py +++ b/searx/engines/demo_offline.py @@ -56,7 +56,6 @@ def search(query, request_params): results. """ - global _my_offline_engine # pylint: disable=global-statement ret_val = [] result_list = json.loads(_my_offline_engine) diff --git a/searx/engines/redis_server.py b/searx/engines/redis_server.py index a48f0775b..f9726033d 100644 --- a/searx/engines/redis_server.py +++ b/searx/engines/redis_server.py @@ -31,8 +31,6 @@ def init(_engine_settings): ) def search(query, _params): - global _redis_client # pylint: disable=global-statement - if not exact_match_only: return search_keys(query) @@ -55,8 +53,6 @@ def search(query, _params): return [] def search_keys(query): - global _redis_client # pylint: disable=global-statement - ret = [] for key in _redis_client.scan_iter( match='*{}*'.format(query) diff --git a/searx/engines/sqlite.py b/searx/engines/sqlite.py index 292448602..43a85efbb 100644 --- a/searx/engines/sqlite.py +++ b/searx/engines/sqlite.py @@ -35,7 +35,6 @@ def sqlite_cursor(): * https://docs.python.org/3/library/sqlite3.html#sqlite3.connect * https://www.sqlite.org/uri.html """ - global database # pylint: disable=global-statement uri = 'file:' + database + '?mode=ro' with contextlib.closing(sqlite3.connect(uri, uri=True)) as connect: connect.row_factory = sqlite3.Row @@ -44,7 +43,6 @@ def sqlite_cursor(): def search(query, params): - global query_str, result_template # pylint: disable=global-statement results = [] query_params = { diff --git a/searx/engines/yggtorrent.py b/searx/engines/yggtorrent.py index ca008c472..31a0408b8 100644 --- a/searx/engines/yggtorrent.py +++ b/searx/engines/yggtorrent.py @@ -37,7 +37,6 @@ cookies = dict() def init(engine_settings=None): - global cookies # initial cookies resp = http_get(url, allow_redirects=False) if resp.ok: |