1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
|
# SPDX-FileCopyrightText: Florian Bruhin (The Compiler) <mail@qutebrowser.org>
#
# SPDX-License-Identifier: GPL-3.0-or-later
"""Unit tests for notification support."""
import logging
import itertools
import inspect
from typing import List, Dict, Any, Optional, TYPE_CHECKING
import pytest
from qutebrowser.qt.core import pyqtSignal, pyqtSlot, QUrl, QObject
from qutebrowser.qt.gui import QImage
from qutebrowser.qt.dbus import QDBusMessage, QDBus, QDBusConnection
pytest.importorskip("qutebrowser.qt.webenginecore")
if TYPE_CHECKING:
from qutebrowser.qt.webenginecore import QWebEngineNotification
from qutebrowser.config import configdata
from qutebrowser.misc import objects
from qutebrowser.browser.webengine import notification
class FakeDBusMessage:
def __init__(
self,
signature: str,
*arguments: Any,
typ: QDBusMessage.MessageType = QDBusMessage.MessageType.ReplyMessage,
error_name: Optional[str] = None,
) -> None:
self._signature = signature
self._arguments = arguments
self._type = typ
self._error_name = error_name
def arguments(self) -> List[Any]:
return self._arguments
def signature(self) -> str:
return self._signature
def type(self) -> QDBusMessage.MessageType:
return self._type
def errorName(self) -> str:
assert self._error_name is not None
return self._error_name
def errorMessage(self):
assert self._error_name is not None
return f"error: {self._error_name}"
@classmethod
def create_error(cls, error_name: str) -> "FakeDBusMessage":
return cls(
"s",
f"error argument: {error_name}",
typ=QDBusMessage.MessageType.ErrorMessage,
error_name=error_name,
)
class FakeDBusInterface:
CAPABILITIES_REPLY = FakeDBusMessage("as", ["actions"])
SERVER_INFO_REPLY = FakeDBusMessage(
"ssss",
"fake notification server", # name
"qutebrowser", # vendor
"v0.0.1", # version
"1.2", # spec version
)
def __init__(
self,
service: str,
path: str,
interface: str,
bus: QDBusConnection,
) -> None:
assert service.startswith(notification.DBusNotificationAdapter.TEST_SERVICE)
assert path == notification.DBusNotificationAdapter.PATH
assert interface == notification.DBusNotificationAdapter.INTERFACE
self.notify_reply = None
def isValid(self) -> bool:
return True
def call(self, mode: QDBus.CallMode, method: str, *args: Any) -> FakeDBusMessage:
meth = getattr(self, f"_call_{method}")
return meth(*args)
def _call_GetCapabilities(self) -> FakeDBusMessage:
return self.CAPABILITIES_REPLY
def _call_GetServerInformation(self) -> FakeDBusMessage:
return self.SERVER_INFO_REPLY
def _call_Notify(
self,
appname: str,
replaces_id: int,
icon: str,
title: str,
body: str,
actions: List[str],
hints: Dict[str, Any],
timeout: int,
) -> FakeDBusMessage:
assert self.notify_reply is not None
return self.notify_reply
class FakeWebEngineNotification(QObject):
closed = pyqtSignal()
def origin(self) -> QUrl:
return QUrl("https://example.org")
def icon(self) -> QImage:
return QImage()
def title(self) -> str:
return "notification title"
def message(self) -> str:
return "notification message"
def tag(self) -> None:
return None
def show(self) -> None:
pass
@pytest.fixture
def fake_notification():
return FakeWebEngineNotification()
def _get_notification_adapters():
return [value for _name, value in inspect.getmembers(notification, lambda obj: (
inspect.isclass(obj) and
issubclass(obj, notification.AbstractNotificationAdapter) and
obj is not notification.AbstractNotificationAdapter
))]
@pytest.mark.parametrize("klass", _get_notification_adapters())
def test_name_attribute(klass, configdata_init):
values = configdata.DATA["content.notifications.presenter"].typ.valid_values
assert klass.NAME not in {"auto", "qt"}
assert klass.NAME in values
class FakeNotificationAdapter(notification.AbstractNotificationAdapter):
NAME = "fake"
def __init__(self) -> None:
super().__init__()
self.presented = []
self.id_gen = itertools.count(1)
def present(
self,
qt_notification: "QWebEngineNotification", *,
replaces_id: Optional[int],
) -> int:
self.presented.append(qt_notification)
return next(self.id_gen)
@pyqtSlot(int)
def on_web_closed(self, notification_id: int) -> None:
"""Called when a notification was closed by the website."""
raise NotImplementedError
@pytest.mark.linux
class TestDBus:
NO_REPLY_ERROR = FakeDBusMessage.create_error("org.freedesktop.DBus.Error.NoReply")
FATAL_ERROR = FakeDBusMessage.create_error("test")
@pytest.fixture
def dbus_adapter_patches(self, monkeypatch, config_stub):
monkeypatch.setattr(objects, "debug_flags", ["test-notification-service"])
monkeypatch.setattr(notification, "QDBusInterface", FakeDBusInterface)
@pytest.fixture
def dbus_adapter(self, dbus_adapter_patches):
return notification.DBusNotificationAdapter()
@pytest.fixture
def dbus_presenter(self, dbus_adapter_patches, monkeypatch):
monkeypatch.setattr(
notification.NotificationBridgePresenter,
"_get_adapter_candidates",
lambda _self, _setting: [
notification.DBusNotificationAdapter,
FakeNotificationAdapter,
],
)
return notification.NotificationBridgePresenter()
def test_notify_fatal_error(self, dbus_adapter, fake_notification):
dbus_adapter.interface.notify_reply = self.FATAL_ERROR
with pytest.raises(notification.DBusError):
dbus_adapter.present(fake_notification, replaces_id=None)
def test_notify_fatal_error_presenter(self, dbus_presenter, fake_notification):
dbus_presenter._init_adapter()
dbus_presenter._adapter.interface.notify_reply = self.FATAL_ERROR
with pytest.raises(notification.DBusError):
dbus_presenter.present(fake_notification)
def test_notify_non_fatal_error(self, qtbot, dbus_adapter, fake_notification):
dbus_adapter.interface.notify_reply = self.NO_REPLY_ERROR
with qtbot.wait_signal(dbus_adapter.error) as blocker:
dbus_adapter.present(fake_notification, replaces_id=None)
assert blocker.args == [f"error: {self.NO_REPLY_ERROR.errorName()}"]
def test_notify_non_fatal_error_presenter(
self,
dbus_presenter,
fake_notification,
caplog,
):
dbus_presenter._init_adapter()
dbus_presenter._adapter.interface.notify_reply = self.NO_REPLY_ERROR
with caplog.at_level(logging.ERROR):
dbus_presenter.present(fake_notification)
message = (
'Notification error from libnotify adapter: '
f'{self.NO_REPLY_ERROR.errorMessage()}'
)
assert message in caplog.messages
assert dbus_presenter._adapter is None # adapter dropped
@pytest.mark.parametrize("error, exctype", [
(NO_REPLY_ERROR, notification.DBusError),
(FATAL_ERROR, notification.Error),
])
def test_capabilities_error(
self,
dbus_adapter_patches,
monkeypatch,
error,
exctype,
):
monkeypatch.setattr(FakeDBusInterface, "CAPABILITIES_REPLY", error)
with pytest.raises(exctype):
notification.DBusNotificationAdapter()
@pytest.mark.parametrize("error", [NO_REPLY_ERROR, FATAL_ERROR],
ids=lambda e: e.errorName())
def test_capabilities_error_presenter(
self,
dbus_presenter,
fake_notification,
monkeypatch,
caplog,
error,
):
monkeypatch.setattr(FakeDBusInterface, "CAPABILITIES_REPLY", error)
dbus_presenter.present(fake_notification)
message = (
'Failed to initialize libnotify notification adapter: '
f'{error.errorName()}: {error.errorMessage()}'
)
assert message in caplog.messages
assert isinstance(dbus_presenter._adapter, FakeNotificationAdapter)
assert dbus_presenter._adapter.presented == [fake_notification]
|