Age | Commit message (Collapse) | Author |
|
|
|
|
|
|
|
Closes #6015
|
|
|
|
|
|
The behavior when pressing `v` in line selection mode was different between
QtWebKit and QtWebEngine: With QtWebKit, normal selection mode was entered,
while with QtWebEngine, selection mode was left.
Do the former with QtWebEngine as well, as that's also what vim does.
|
|
Otherwise, the caret JS code could still be initializing while the tests start
to run.
|
|
See #5459
|
|
|
|
For some odd reason, loading the file sometimes takes >5s on macOS...
See https://github.com/qutebrowser/qutebrowser/issues/5390#issuecomment-629269038
|
|
|
|
With newer Qt versions, it looks like the caret window always needs to be shown
for the selection to work correctly. However, the test silently passed when no
selection was available.
|
|
|
|
|
|
On macOS, doing :move-to-end-of-line after :toggle-selection still moves the
right cursor (rather than the left), causing our test to fail. Running the
equivalent JS snippet on Chrome reveals the same behavior, so let's just use
some other movement for the test.
Fixes #4694
|
|
With 5.13 `window.getSelection()` (which we use to find the focused
element) appears to require this expose thing.
See 85f95f6f41567 for the same workaround for hint tests.
https://github.com/qutebrowser/qutebrowser/issues/4592
|
|
|
|
|
|
Also changed one of the tests to be a better test of reversing the
selection. `tests/unit/browser/test_caret.py:TestReverse:test_reverse`
reverses the selection multiple times and tests out motions several
times, making sure that the selection can be reversed more than once (I
had a bug where the selection was reversed only once), and the selection
is updated correctly after several motions.
Changes to be committed:
modified: tests/end2end/features/caret.feature
modified: tests/unit/browser/test_caret.py
|
|
We still call the :open command openurl, but in the tab API and in
TabbedBrowser it's now called load_url.
|
|
This avoids odd X errors with test_webenginetab.py, and also makes it run much
faster (0.8s instead of 1.3s).
|
|
|
|
|
|
|
|
|
|
|
|
|
|
In Qt < 5.10 (and also sometimes on Windows), we get extra spaces or newlines
when moving to the end of the document. However, this only happens *sometimes*,
and manual testing confirms that with the current workaround, we actually lose
the last char in the selection.
I'm not sure what's happening there, but instead of making things worse with
the workaround, let's just be a bit less strict with the checking there and
accept both variants... This seems like some Chromium bug we can't do much
about.
|
|
|
|
|
|
|
|
|
|
This reverts commit 200c11625f4dd6fb2a36f3dcb674402918da6c79.
|
|
This reverts commit bc45aa33e0ac58e8ccd54508b36dc0b463c4c3c3.
|
|
|
|
|
|
|
|
This is more lightweight than running a webserver (probably about the same as
file://), but allows us to use relative links in files.
|
|
|
|
|
|
For some reason, they need the window to be shown on a screen to work...
|
|
|