Age | Commit message (Collapse) | Author |
|
|
|
|
|
See #5904
|
|
|
|
|
|
|
|
Follow-up to c1758230200814e84055f3e2954cb69f0fddf5d8, see #6393
|
|
|
|
Otherwise, if there's a fatal error message shown during init, we try to
open something via IPC before we're fully initialized. This can e.g.
lead to a KeyError for qtnetwork-download-manager:
Traceback (most recent call last):
File "/usr/lib/python3/dist-packages/qutebrowser/app.py", line 120, in <lambda>
process_pos_args(args, cwd=cwd, via_ipc=True,
File "/usr/lib/python3/dist-packages/qutebrowser/app.py", line 230, in process_pos_args
win_id = mainwindow.get_window(via_ipc, force_window=True)
File "/usr/lib/python3/dist-packages/qutebrowser/mainwindow/mainwindow.py", line 89, in get_window
window = MainWindow(private=None)
File "/usr/lib/python3/dist-packages/qutebrowser/mainwindow/mainwindow.py", line 220, in __init__
self._init_downloadmanager()
File "/usr/lib/python3/dist-packages/qutebrowser/mainwindow/mainwindow.py", line 350, in _init_downloadmanager
qtnetwork_download_manager = objreg.get('qtnetwork-download-manager')
File "/usr/lib/python3/dist-packages/qutebrowser/utils/objreg.py", line 249, in get
return reg[name]
File "/usr/lib/python3.8/collections/__init__.py", line 1010, in __getitem__
raise KeyError(key)
KeyError: 'qtnetwork-download-manager'
|
|
|
|
|
|
This reverts commit 1132324db9d665ba0f0143fb1d071995a3fc7715.
Causes various issues with Qt/QtWebEngine shortcuts.
Fixes #6174
Closes #6149
|
|
This means sessions need to be initialized after websettings, because
initializing websettings also initializes QtWebEngine and thus
qutescheme. This needs to happen before sessions.init() calls
version.webengine_versions(). I don't think this should be a problem, as
they are independent to each other.
Fixes #5738
See #5359
Also switches sessions.init() to pathlib, see #176.
|
|
When using open_url_in_instance.sh, it runs qutebrowser passing a single
empty argument to it. This doesn't properly open a new window, but opens
a window without any tabs instead. Interacting with that will then lead
to a RegistryUnavailableError.
We now special-case that behavior, though there might be a more involved
proper fix for "" handling needed at a later point.
Fixes #6122
|
|
|
|
|
|
Also don't show it for new users - this doesn't really help much if
someone just started using qutebrowser.
See #5359
|
|
|
|
Closes #6015
|
|
# Conflicts:
# qutebrowser/app.py
|
|
We know that QApplication.instance() will always be non-None for
practical purposes, but the stubs now (correctly) declare it as
Optional.
See https://github.com/stlehmann/PyQt5-stubs/pull/126
|
|
See #5395
|
|
|
|
|
|
|
|
|
|
|
|
Fixes #5245
|
|
|
|
|
|
|
|
|
|
|
|
I believe this should close #5396
|
|
|
|
|
|
The previous change (asking when a conflicting download is running) caused RuntimeErrors
because some stuff was already cleaned up when trying to remove them from the download
model. Probably something (e.g. storing self._manager in DownloadItems) shifted around
the order things are cleaned up.
Instead, clean up downloads explicitly by cancelling them all when shutting down.
|
|
All callers except one passed force_target anyways.
|
|
This partially reverts efaa721ef72953786db05b305815e801d2dcd52a so that it
doesn't actually change any behavior, as the change breaks tests.
Reopens #1328
|
|
This also should properly fix #1328 since we now always force 'tab-silent' for
commands, instead of only forcing it when the setting is set to 'window'
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
It is an arbitrary limit for now. We can make in configurable once #4814
adds such a config option.
The only time I can imagine someone would want more than 100 entries is
if they have tabs_are_windows and more than 100 windows open and do
:window-only by mistake.
Tested by doing `:repeat 110 open -w about:blank`, `:window-only`,
`:repeat 110 undo -w` and looking at the window IDs in the buffer
completion.
|
|
|
|
I don't like using `QApplication.instance()` and then calling methods
that aren't defined for a `QApplication` on it. We need to sort our
module heirarchy out though because there would be an import loop from
importing app here.
|