Age | Commit message (Collapse) | Author |
|
Releases are probably important enough
|
|
|
|
|
|
See https://github.com/softprops/action-gh-release/issues/163
|
|
Regressed in c2210539a9e2be1deacf8df8f432e035d9b9b9f0:
The current NSIS installer still adds the suffix. Let's keep it there for now
until we switch to the rewritten one.
See #6050
|
|
See https://blog.pypi.org/posts/2023-05-23-removing-pgp/
|
|
Regressed in c2210539a9e2be1deacf8df8f432e035d9b9b9f0:
We don't want to return a list of lists.
|
|
|
|
|
|
|
|
|
|
|
|
By default, we only get a narrow checkout, so we don't know about any
other branches. Use the GitHub API and some JS to get the release branch
instead.
|
|
See #3725
|
|
Follow-up to a46e9f2036595e8d04cae68a719e5182718861bf to work correctly with
older Qt versions (< 6.4), where this is not a QQuickWidget apparently.
This also means we can simplify the workaround, as we are guaranteed to be on Qt
6.4+ anyways.
See #7820, #7831
|
|
When pressing buttons on some websites, or when starting to drag, it looks like
the WebView gets new QObject children which are not actually their focus proxy.
So far, this wasn't a big issue: We only ended up installing the tab event
filter on objects where it doesn't belong.
However, with the new focus workaround from #7820, we then ended up calling
`.setFocus()` on those QObjects, causing an AttributeError.
Thus, just don't do anything if we get new children that are not actually a
QQuickWidget.
Fixes #7831
|
|
|
|
Opening a download in a new tab leaves a "dead" tab (see example of a "dead" tab below)
behind. When saving a session containing such a "dead" tab, we end up with entries in
the session like this one:
```yaml
- active: true
history:
- active: true
last_visited: '1970-01-01T02:00:00'
pinned: false
scroll-pos:
x: 0
y: 0
title: ''
url: ''
zoom: 1.0
```
When loading a session containing such a "dead" tab, qutebrowser does not restore any
history of that session and logs the following error:
```
ERROR: Failed to load session default: PyQt6.QtCore.QUrl('') is not valid
```
As pointed out by @The-Compiler in this comment[1], the behavior of
`QWebEngineHistoryItem::isValid()`[2] changed somehow between Qt 6.4 and 6.5.
`QWebEngineHistoryItem::isValid()` now returns `True` for "dead" tabs, even though the
history item is not valid (i.e. `url().isValid()` returns `False`).
To fix this we simply add an additional check if the URL is valid before adding a tab to
the session to be saved.
[1] https://github.com/qutebrowser/qutebrowser/issues/7696#issuecomment-1672854592
[2] https://github.com/qt/qtwebengine/blob/v6.5.2/src/core/api/qwebenginehistory.cpp#L69-L75
|
|
|
|
|
|
Follow-up to #7809, see #7214
|
|
|
|
|
|
|
|
Hopefully makes it more reliable
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
Fails without the fix on main on QtWebEngine 6.4 (works on 6.2).
Works fine after the fix.
See #7820
|
|
See https://github.com/pallets/werkzeug/commit/5ff0a573f4b78d9724f1f063fb058fd6bc76b24d
With that commit, encoding the header ourselves means that we'll actually be
navigating to the path `/b'data/...'` instead of `/data/...`.
|
|
Don't rely on the global QApplication.focusWidget()
See #7820
|
|
Fixes #7820
|
|
Shows objectName() and the metaObject().className() if available.
More debug info for #7820
|
|
This partially solves #7820. The web view still loses focus for an unknown
reason (apparently when swtiching out the rendering process?), but at least it
regains focus now when the window is unfocused and then focused again.
|
|
|
|
Looks like the version check was wrong
|
|
See https://github.com/python/mypy/issues/15870
|
|
Seems to show as 50 instead of 65 somehow...
|
|
|
|
qutebrowser/feat/mac_sandbox_pre_release_pyinstaller
Feat/mac sandbox pre release pyinstaller
|
|
The CheckPlatform macro will prompt the user user to use the 32bit installer
if they are on a 32bit system. But we don't provide a 32bit installer anymore.
This commit changes the OS version check for Qt5 builds to be based on checking
version numbers ourselves too, so that we can have our own error message.
Also moves the Qt5 conditionals to be compile time ones.
|
|
|
|
We dropped 32bit support in #7804 and as a result removed the arch
suffix from the binary that pyinstaller produces. This commit removes it
form the lookup path in the installer too.
Note that we are leaving the arch string in the installer itself for
now. Mostly because it'll be removed as part of a later change when the
installer itself is refreshed. But it might also be useful to clarify in
the installer names what the arch is? Maybe, that reasoning might not
fit with the previous change to remove the arch strings.
|
|
The Qt docs for 6.5 say that the minimum supported version is Windows 10
1809.
Experimentally it seems qutebrowser and it's dependencies work fine on a
version as early 1607.
There should be no change in OS version requirements for the Qt5 build,
although we've dropped 32 bit support already and in a future version of
the installer we may bring the minimum OS version support in line with
the Qt6 requirements for simplicity too.
Added a new QT5 version into the NSIS scripts so we can do the different
version check per installer build. It just uses the python bool
serialization format so should always be "True" or "False", but I've
added a fallback anyway for consistency.
|