Age | Commit message (Collapse) | Author |
|
|
|
|
|
|
|
It doesn't know about QMessageLogContext.lineno being Optional[int] rather than
int.
|
|
|
|
If lineno is set to None in the LogRecord, pytest's logging formatting fails:
tests/unit/utils/test_log.py:418: in test_empty_message
log.qt_message_handler(QtCore.QtDebugMsg, self.Context(), "")
qutebrowser/utils/log.py:508: in qt_message_handler
qt.handle(record)
/usr/lib/python3.8/logging/__init__.py:1587: in handle
self.callHandlers(record)
/usr/lib/python3.8/logging/__init__.py:1649: in callHandlers
hdlr.handle(record)
/usr/lib/python3.8/logging/__init__.py:950: in handle
self.emit(record)
../../pytest/src/_pytest/logging.py:326: in emit
super().emit(record)
/usr/lib/python3.8/logging/__init__.py:1089: in emit
self.handleError(record)
/usr/lib/python3.8/logging/__init__.py:1081: in emit
msg = self.format(record)
/usr/lib/python3.8/logging/__init__.py:925: in format
return fmt.format(record)
../../pytest/src/_pytest/logging.py:89: in format
return super().format(record)
/usr/lib/python3.8/logging/__init__.py:667: in format
s = self.formatMessage(record)
/usr/lib/python3.8/logging/__init__.py:636: in formatMessage
return self._style.format(record)
../../pytest/src/_pytest/logging.py:185: in format
return self._fmt % record.__dict__
E TypeError: %d format: a number is required, not NoneType
According to typeshed, lineno should never be None:
https://github.com/python/typeshed/blob/028f0d52931fe1f96bb25d066186961159c1f801/stdlib/2and3/logging/__init__.pyi#L386
Thus, this is our fault, not pytest's. However, before pytest 6.0.0, pytest did
not surface logging errors:
https://github.com/pytest-dev/pytest/pull/7231
https://github.com/pytest-dev/pytest/commit/b13fcb23d79b3f38e497824c438c926a0a015561
Thus, we never noticed something was going wrong here.
|
|
|
|
|
|
|
|
|
|
See #5421
|
|
See #5421
|
|
Preparation for proper handling as part of #5421
|
|
Preparation for some changes for #5421
|
|
|
|
Otherwise, with a "KeyError: 1" we will only get "1" as message.
|
|
|
|
Let's not match on so much unrelated stuff...
|
|
This should also color tox output, and it doesn't conflict with PYTEST_ADDOPTS
being used for coverage options.
|
|
Not in people's custom forks
|
|
|
|
See #5559
|
|
|
|
Really doesn't work, and I should play around with this in a branch rather than
master (sorry!).
|
|
|
|
Gets the latest shellcheck binary release.
Closes #5567
|
|
|
|
|
|
|
|
qutebrowser/dependabot/github_actions/codecov/codecov-action-v1.0.10
build(deps): Bump codecov/codecov-action from v1 to v1.0.10
|
|
qutebrowser/dependabot/github_actions/actions/setup-node-v2.1.0
build(deps): Bump actions/setup-node from v1 to v2.1.0
|
|
Update dependencies
|
|
Bumps [actions/setup-node](https://github.com/actions/setup-node) from v1 to v2.1.0.
- [Release notes](https://github.com/actions/setup-node/releases)
- [Commits](https://github.com/actions/setup-node/compare/v1...1ae8f4b1fd89676f69b55d3dd6932b6df089ff7b)
Signed-off-by: dependabot[bot] <support@github.com>
|
|
Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from v1 to v1.0.10.
- [Release notes](https://github.com/codecov/codecov-action/releases)
- [Commits](https://github.com/codecov/codecov-action/compare/v1...f3570723ef743f6942b6a480461ed0cd6c0f9baa)
Signed-off-by: dependabot[bot] <support@github.com>
|
|
We don't use it for Python (because, among other reasons, it can't bundle PRs).
There, we use recompile_requirements.py instead.
|
|
Doesn't seem to work like this...
|
|
Based on my qutebrowser bookmarks \o/
|
|
We need to have a message for the file/line we get from a stacktrace - let's
see if it works out to take it from the next "E ..." line.
|
|
Don't match every single line of a stacktrace.
|
|
|
|
|
|
|
|
|
|
It really seems to fail every time, and GitHub's UI still prominently shows the
failure.
|
|
|
|
|
|
Hopefully fixes things on Docker
|
|
|
|
|
|
While trying to simplify the data structure, we didn't consider a case where we
want to register multiple matchers with the same severity...
Let's simplify things a bit, by having a list of matchers in the data. Also
attempt to pass that list to GitHub, because they support doing so, in
theory...
|