| Age | Commit message (Collapse) | Author |
|---|
|
This reverts commit 6042fccbf58955dba251e833d3ed4d66d79102e9.
|
|
|
|
This reverts commit 64af5f0e264f5a79dc474838603f584b346f6ac4.
|
|
|
|
This reverts commit 23979c147fae27e32af8812346a56bef18d89c3e.
|
|
|
|
|
|
Because we don't catch the exception and then the whole script bails out
so we don't end up printing the error log from the process.
Keep raising on --debug just to maintain the behaviour, eg fail the
build if the process fails.
I'm not sure we actually want this behaviour though. As it is we won't
get the output printed out on failed debug builds. So maybe we
shouldn't be skipping the output check? I don't quite get what the
intention is here.
|
|
qt6 is the default now
|
|
Seems to be passing the smoke test now!
TODO: sort out the debug build stdout/err situation
* I changed smoke_test() to fail on unexpected lines from debug builds
too
* then I asked pyinstaller to trace imports (-v) for debug builds
* so a top level --debug build will always fail currently
* previously unexpected lines where checked for top level debug builds
* but the output was also not printed at all, which isn't helpful
* quite possibly I would have got the correct info from a
non-top-level-debug run in the first place (except they all timed
out), but then what's the point of the top level debug runs?
* I think the --debug to get qutebrowser output and whatever the top
level debug (eg used from the workflow file) is used for are being
conflated
Also try with the tip of develop of pyinstaller again and see if that
works now we are rebuilding the bootloader.
|
|
I don't get it. If you capture the output on a debug build and don't
print it what's the point? And why have --debug args in the workflow if
debug is supposed to be called from a failure in the non debug build? I
feel like I'm missing something here.
Hopefully this lets me actually see some output in CI ...
|
|
|
|
It's very very slow and there are many GBs to upload on the mac build.
Also build window non-debug so it does an actual smoke test.
|
|
Also print output on --debug runs too
|
|
For windows I'm getting a "Module not found." error, which I suspect is
it not finding qutebrowser itself, but lets see.
ref: https://pyinstaller.org/en/stable/spec-files.html#giving-run-time-python-options
|
|
|
|
|
|
|
|
|
|
I want to try running these builds from a branch other than master.
Workflows with workflow_dispatch let you specify a branch to run on,
scheduled runs run on the default branch anyway, so hardcoding the
branch doesn't seem helpful.
This can be ported to the proper nightly.yml too if it works.
|
|
Updates tox pyinstaller job to specify QUTE_QT_WRAPPER - needed until
autoselection of Qt wrapper is enabled.
Hacks git+https://github.com/pyinstaller/pyinstaller.git@develop into
the pyinstaller tox env, since the point of this is to test the upcoming
pyinstaller 6 release from a banch.
Removes the pyinstaller requirements file from the build_release tox job
because I don't think it's needed there (the build_release script calls
pyinstaller via tox).
|
|
|
|
|
|
qutebrowser/dependabot/github_actions/actions/setup-node-4
build(deps): bump actions/setup-node from 3 to 4
|
|
Bumps [actions/setup-node](https://github.com/actions/setup-node) from 3 to 4.
- [Release notes](https://github.com/actions/setup-node/releases)
- [Commits](https://github.com/actions/setup-node/compare/v3...v4)
---
updated-dependencies:
- dependency-name: actions/setup-node
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
|
|
Update dependencies
|
|
|
|
if -> is
where -> were
|
|
(cherry picked from commit f4ba52d33fb73a44a9298098d062987f23fb79db)
|
|
|
|
(cherry picked from commit b3b1384037f0717a1905c67c69b887034345221c)
|
|
|
|
This reverts commit 597873286c78c1a998367c565125d0c0cb45b905.
|
|
|
|
Not needed on CI for a reason I don't quite understand, but needed locally for things to run.
|
|
|
|
Update dependencies
|
|
|
|
|
|
See https://riverbankcomputing.com/news/SIP_v6.7.12_Released
|
|
|
|
|
|
See https://mypy-lang.blogspot.com/2023/10/mypy-16-released.html
|
|
|
|
Update dependencies
|
|
https://pylint.readthedocs.io/en/stable/user_guide/messages/refactor/prefer-typing-namedtuple.html
Says to using the class based typing.NamedTuple instead of
collections.namedtuple, which just constructs a class based off of
strings.
Here we are creating a dynamic class based on the fields in the SQL result.
It's only called once for a query, so I don't think speed is an issue.
Also it's not used by the completion, looks like just :history
|
|
With pylint 3 there is a new option: https://pylint.readthedocs.io/en/latest/user_guide/messages/convention/use-implicit-booleaness-not-comparison-to-zero.html
It's disabled by default but we enable all warnings and disabled them as
desired.
This one is of the opinion that:
if x == 0:
is bad and
if x:
is good.
I feel that the first one (x == 0) is more clear. We aren't checking for
truthiness here, we are checking for a literal value, its very
intentional.
One might argue that being precious about making the type here is
redundant in current year with type checking tooling and all that. But
there are like a hundred of these checks in the code base so it seems a
well established pattern anyhow.
In summary, the new warning doesn't have a very strong use case and we
would prefer to stick with out established pattern.
|
|
Was getting R0913: Too many arguments (14/10) (too-many-arguments)
no idea what that is just showing up now
|
|
|
|
|
