Age | Commit message (Collapse) | Author |
|
I'm running mypy like so:
mypy --always-true=USE_PYQT6 --always-false=USE_PYQT5 --always-false=USE_PYSIDE2 --always-false=USE_PYSIDE6 --always-false=IS_QT5 --always-true=IS_QT6 qutebrowser/
And I just went down the output fixing easy stuff.
Currently I'm getting 61 errors on Qt5 and 207 errors on Qt6 (down from
230 or so).
I think the comparison ignores I removed are still needed on Qt5. I'm
not sure how best to deal with situations that need to be ignored on one
implementation and not on another. One way to do it would be to have
alternate implementations per backend, but that could become a bit or a
maintenance burden, see https://github.com/python/mypy/issues/8823
I'm also seeing some "Statement is unreachable" errors popping up which
might be due to the same scenario.
Many of the errors are related to there being no webkit on Qt6 so the
webkit modules get resolved as ANY which makes all the # type: ignore
messages be complained about. Not sure what we can do about that,
possibly something from https://mypy.readthedocs.io/en/stable/command_line.html#cmdoption-mypy-exclude
I see that Phil said we shouldn't need separate stubs for PyQt6. I'm
still using them and haven't tried without yet.
|
|
Allows for some rudimentary debugging of subprocesses.
|
|
See #7314 and #6097
|
|
See https://bugreports.qt.io/browse/QTBUG-104741 and #7314
|
|
See #7314
|
|
With Qt 6.4, it looks like the full UA disappeared from the ELF string
table - see previosly: db1382f75c975ea94ad962444cc0e536a963cb81
However, the full Chromium version string is still stored separately,
most likely for qWebEngineChromiumVersion() - so let's go hunt for that.
Note that this code won't be used for most situations, as with an up-to-
date PyQt, we finally have an API to access this information properly.
But it's still useful as a fallback in strange situations like running
an older PyQt against a newer Qt.
See #7314
|
|
See #7314
|
|
Doesn't fix the issue in #7314 as we are on PyQt 6.3
|
|
We can use negative factors now, and Qt 6.2/6.3 can be simplified too.
See https://tox.wiki/en/latest/config.html#complex-factor-conditions
|
|
This avoids the temptation of creating a Qt.Key() manually, which needs
to be checked for ValueError with PyQt 6.2 due to its handling of unknown enum
values.
This is exactly what happened in RegisterKeyParser, which caused such a
ValueError:
https://github.com/qutebrowser/qutebrowser/issues/7047#issuecomment-1163288560
Closes #7047
|
|
processId() got introduced in Qt 5.3
FIXME: pick to master?
|
|
|
|
See #7278
|
|
|
|
|
|
|
|
|
|
See #7252
|
|
See #7278
|
|
Fixes #7267
|
|
Closes #7258
|
|
This reverts commit 400dbc8de3139d2a7015bcf58f14e56c46f3bdb9.
|
|
|
|
|
|
Fixes https://github.com/qutebrowser/qutebrowser/issues/7257
|
|
See #7255 and #7256
|
|
See #7252
|
|
See #7252
|
|
See #7258
|
|
|
|
32-bit Windows support got dropped, macOS arm64 (M1) support added.
|
|
|
|
Seems to be called rather infrequently (when focusing some other window
even?) but then crash with:
Traceback (most recent call last):
File ".../qutebrowser/completion/completiondelegate.py", line 323, in paint
self._draw_focus_rect()
File ".../qutebrowser/completion/completiondelegate.py", line 263, in _draw_focus_rect
o.state |= int(QStyle.StateFlag.State_KeyboardFocusChange | QStyle.StateFlag.State_Item)
TypeError: int() argument must be a string, a bytes-like object or a real number, not 'StateFlag'
|
|
This reverts commit 14c1593de2abd9f24a223805a4740d8d9fd93622.
Fixed in Python 3.11b2: https://github.com/python/cpython/pull/93302
|
|
See #7220
|
|
Fixes #7206
|
|
Needed it for debugging, so why not implement it properly.
TODO: Changelog, pick to master?
|
|
|
|
|
|
|
|
|
|
|
|
Also changes reloaded -> reload for consistency
(both to Qt and between the names).
|
|
Fixed in sip 5.3.0 (May 31st, 2020), so should not be a problem
since Qt 5.15.0 (June 1st, 2020).
|
|
See https://github.com/qutebrowser/qutebrowser/runs/6658849317?check_suite_focus=true
|
|
_QOpenGLFunctions_2_0 was added in 2df9508e44cd6839075c7be725fb13ced4563a08 but
doesn't seem to be needed anymore. PyQt 6 doesn't seem to need any hiddenimports
at all.
|
|
|
|
|
|
The icon change doesn't seem to have any effect anymore (those environment
variables might be isolated from Chromium rendering processes since some Qt
update). The name change isn't needed anymore with QtWebEngine 5.15.2
which is now the oldest supported version.
See #3832
|
|
|