summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2022-08-25Some Qt6 mypy fixesfeat/pyqt6_and_mypytoofar
I'm running mypy like so: mypy --always-true=USE_PYQT6 --always-false=USE_PYQT5 --always-false=USE_PYSIDE2 --always-false=USE_PYSIDE6 --always-false=IS_QT5 --always-true=IS_QT6 qutebrowser/ And I just went down the output fixing easy stuff. Currently I'm getting 61 errors on Qt5 and 207 errors on Qt6 (down from 230 or so). I think the comparison ignores I removed are still needed on Qt5. I'm not sure how best to deal with situations that need to be ignored on one implementation and not on another. One way to do it would be to have alternate implementations per backend, but that could become a bit or a maintenance burden, see https://github.com/python/mypy/issues/8823 I'm also seeing some "Statement is unreachable" errors popping up which might be due to the same scenario. Many of the errors are related to there being no webkit on Qt6 so the webkit modules get resolved as ANY which makes all the # type: ignore messages be complained about. Not sure what we can do about that, possibly something from https://mypy.readthedocs.io/en/stable/command_line.html#cmdoption-mypy-exclude I see that Phil said we shouldn't need separate stubs for PyQt6. I'm still using them and haven't tried without yet.
2022-07-19quteprocess: Add --qute-delay-startFlorian Bruhin
Allows for some rudimentary debugging of subprocesses.
2022-07-15Qt 6.4: Adjust dark mode testsFlorian Bruhin
See #7314 and #6097
2022-07-15Qt 6.4: Hide bogus 'GL format 0 is not supported' messageFlorian Bruhin
See https://bugreports.qt.io/browse/QTBUG-104741 and #7314
2022-07-15Qt 6.4: Ignore new Chromium cert errors in testsFlorian Bruhin
See #7314
2022-07-15Qt 6.4: elf: More hacks to get versionFlorian Bruhin
With Qt 6.4, it looks like the full UA disappeared from the ELF string table - see previosly: db1382f75c975ea94ad962444cc0e536a963cb81 However, the full Chromium version string is still stored separately, most likely for qWebEngineChromiumVersion() - so let's go hunt for that. Note that this code won't be used for most situations, as with an up-to- date PyQt, we finally have an API to access this information properly. But it's still useful as a fallback in strange situations like running an older PyQt against a newer Qt. See #7314
2022-07-15Qt 6.4: Add --webEngineArgsFlorian Bruhin
See #7314
2022-07-15Qt 6.4: Add initial version infoFlorian Bruhin
Doesn't fix the issue in #7314 as we are on PyQt 6.3
2022-07-06tox: Simplify tox syntaxFlorian Bruhin
We can use negative factors now, and Qt 6.2/6.3 can be simplified too. See https://tox.wiki/en/latest/config.html#complex-factor-conditions
2022-06-22keyutils: Move public functions to KeyInfoFlorian Bruhin
This avoids the temptation of creating a Qt.Key() manually, which needs to be checked for ValueError with PyQt 6.2 due to its handling of unknown enum values. This is exactly what happened in RegisterKeyParser, which caused such a ValueError: https://github.com/qutebrowser/qutebrowser/issues/7047#issuecomment-1163288560 Closes #7047
2022-06-22Avoid deprecated QProcess.pid()Florian Bruhin
processId() got introduced in Qt 5.3 FIXME: pick to master?
2022-06-22Adjust test_notification for Qt 6Florian Bruhin
2022-06-22qt6: Add macOS sandboxing warningFlorian Bruhin
See #7278
2022-06-22build-release: Add suffixes for Qt 6Florian Bruhin
2022-06-22build-release: Also ignore FILE_NOT_FOUND for macOS smoke testFlorian Bruhin
2022-06-22build-release: Make whitelist more fine-grainedFlorian Bruhin
2022-06-22tests: Ignore another Chromium lineFlorian Bruhin
2022-06-22build-release: Reenable partial macOS symlinkingFlorian Bruhin
See #7252
2022-06-22build-release: Ignore sandboxing disabled messageFlorian Bruhin
See #7278
2022-06-22tests: Disable word wrap for rich text testsFlorian Bruhin
Fixes #7267
2022-06-22Switch to PyInstaller master branchFlorian Bruhin
Closes #7258
2022-06-22Revert "wip: Work around PyQt snapshot enum weirdness"Florian Bruhin
This reverts commit 400dbc8de3139d2a7015bcf58f14e56c46f3bdb9.
2022-06-22Upgrade to PyQt6 6.3.1Florian Bruhin
2022-06-22scripts: Add check for direct PyQt importsFlorian Bruhin
2022-06-22mkvenv: Work around QT_DEBUG_PLUGINS crashFlorian Bruhin
Fixes https://github.com/qutebrowser/qutebrowser/issues/7257
2022-06-22build-release: Ignore new macOS warnings temporarilyFlorian Bruhin
See #7255 and #7256
2022-06-22build-release: Increase macOS template size once againFlorian Bruhin
See #7252
2022-06-22pyinstaller: Disable symlink patching for nowFlorian Bruhin
See #7252
2022-06-22macOS: Use patched PyInstallerFlorian Bruhin
See #7258
2022-06-22Update font table commentFlorian Bruhin
2022-06-22scripts: Adjust supported architectures for PyQt6Florian Bruhin
32-bit Windows support got dropped, macOS arm64 (M1) support added.
2022-06-22scripts: Add _is_qt6_version to mkvenvFlorian Bruhin
2022-06-22Remove extra int() for drawing focus rectFlorian Bruhin
Seems to be called rather infrequently (when focusing some other window even?) but then crash with: Traceback (most recent call last): File ".../qutebrowser/completion/completiondelegate.py", line 323, in paint self._draw_focus_rect() File ".../qutebrowser/completion/completiondelegate.py", line 263, in _draw_focus_rect o.state |= int(QStyle.StateFlag.State_KeyboardFocusChange | QStyle.StateFlag.State_Item) TypeError: int() argument must be a string, a bytes-like object or a real number, not 'StateFlag'
2022-06-22Revert "Patch PyQt6 QUrl flag behavior for Python 3.11"Florian Bruhin
This reverts commit 14c1593de2abd9f24a223805a4740d8d9fd93622. Fixed in Python 3.11b2: https://github.com/python/cpython/pull/93302
2022-06-22Set content.local_content_can_access_file_urls to False for userscripts dirFlorian Bruhin
See #7220
2022-06-22Allow remote content access from userscript html filesFlorian Bruhin
Fixes #7206
2022-06-22Add --include-hidden for :config-diffFlorian Bruhin
Needed it for debugging, so why not implement it properly. TODO: Changelog, pick to master?
2022-06-22Update Qt version testFlorian Bruhin
2022-06-22Reintroduce skipped testsFlorian Bruhin
2022-06-22mkvenv: Apply workaround with --pyqt-version 5Florian Bruhin
2022-06-22Improve version detection for software rendering workaroundFlorian Bruhin
2022-06-22Adjust some fixme commentsFlorian Bruhin
2022-06-22test that enums match their Qt equivalentsFlorian Bruhin
Also changes reloaded -> reload for consistency (both to Qt and between the names).
2022-06-22old qt: Remove workaroundFlorian Bruhin
Fixed in sip 5.3.0 (May 31st, 2020), so should not be a problem since Qt 5.15.0 (June 1st, 2020).
2022-06-22Ignore additional chromium messageFlorian Bruhin
See https://github.com/qutebrowser/qutebrowser/runs/6658849317?check_suite_focus=true
2022-06-22Adjust PyInstaller hiddenimportsFlorian Bruhin
_QOpenGLFunctions_2_0 was added in 2df9508e44cd6839075c7be725fb13ced4563a08 but doesn't seem to be needed anymore. PyQt 6 doesn't seem to need any hiddenimports at all.
2022-06-22Adjust _create_module_info for Qt 6Florian Bruhin
2022-06-22Move creating version.MODULE_INFO to a functionFlorian Bruhin
2022-06-22Remove setting Pulseaudio propertiesFlorian Bruhin
The icon change doesn't seem to have any effect anymore (those environment variables might be isolated from Chromium rendering processes since some Qt update). The name change isn't needed anymore with QtWebEngine 5.15.2 which is now the oldest supported version. See #3832
2022-06-22Adjust Qt/PyQt version rangesFlorian Bruhin