Age | Commit message (Collapse) | Author | |
---|---|---|---|
2022-06-13 | Skip test broken on QtWebKitdev | Florian Bruhin | |
(cherry picked from commit d01dd9be07bd1591b1ecda298a2bf84b41ea280c) | |||
2022-06-13 | Fix lint with FindFlags change | Florian Bruhin | |
2022-06-13 | Fix prev_result/next_result with None callbacks | Florian Bruhin | |
2022-06-13 | Add a helper dataclass for find flags | Florian Bruhin | |
When e.g. doing: - '?foo' (search with reverse=True -> FindBackwards) - 'N' (prev_result -> no FindBackwards) - 'n' (next_result -> FindBackwards again) we need to take a copy of the flags so that we can temporarily clear FindBackwards when pressing 'N'. Relevant history: - We originally did int(self._flags) in d4502574856c7d539a0890fbb6b093942c4551b6. - In f0da508c218ad57289bdb9268faeba7b7741a233, we used QWebPage.FindFlags(int(self._flags)) instead. - With 97bdcb8e674c8ff27ab92448effef263880ab3aa (picked from c349fbd18084183d44f351af617f6ad5d16efabf) we instead do: flags = QWebEnginePage.FindFlag(self._flags) Using FindFlag instead of FindFlags seemed to work fine with PyQt6 and enum.Flag. With PyQt5, however, later clearing a flag bit ends up with us getting 0 as an integer, thus losing the type information about this being a FindFlag instance, and resulting in a TypeError when calling into Qt. We could use FindFlags() with PyQt 6 but FindFlag() with PyQt 5 to copy the original flags, but that's getting rather cumbersome. Instead, let's have a helper dataclass of bools, do away with the bit-twiddling, and only convert it to a Qt flags when we actually need them. This solves the copying issue nicely, and also makes the code a lot nicer. Finally, this also adds a test case which fails when the flags are mutated in place instead of copied. We could do the same kind of change for QtWebKit as well, but given that it's somewhat dead - and perhaps more importantly, won't run with Qt 6 - let's not bother. To not break the end2end tests with QtWebKit, the output still is the same as before. (cherry picked from commit 96a0cc39512753445bc7a01b218b2f1290819ddd) | |||
2022-06-13 | search: Split navigation/search callbacks | Florian Bruhin | |
This way, we can move more logic (checking wrapping, etc.) into the API, thus making the commands much more simple and stateless. | |||
2022-06-13 | search: Move wrap argument to next/prev_result | Florian Bruhin | |
The fact that we need to specify this while searching rather than when "zapping" through the results make no sense. It makes both the API as well as our own code more complex. | |||
2022-06-13 | Get rid of _WebEngineSearchWrapHandler | Florian Bruhin | |
2022-06-13 | Add a SearchMatch helper class | Florian Bruhin | |
2022-06-13 | Merge remote-tracking branch 'origin/pr/6670' into dev | Florian Bruhin | |
2022-06-13 | Fix lint | Florian Bruhin | |
2022-06-13 | click-element: Fix typing | Florian Bruhin | |
2022-06-13 | click-element: Unpack lambda dict into if | Florian Bruhin | |
Easier to do assertions, and seems cleaner than storing lambdas. | |||
2022-06-13 | Add setting reference | Florian Bruhin | |
2022-06-13 | Add test for using :prompt-fileselect-external on wrong prompt | Florian Bruhin | |
2022-06-13 | Update docs | Florian Bruhin | |
2022-06-13 | Fix test | Florian Bruhin | |
2022-06-13 | Merge remote-tracking branch 'origin/pr/7003' | Florian Bruhin | |
2022-06-13 | Update docs | Florian Bruhin | |
2022-06-13 | Merge remote-tracking branch 'origin/pr/6448' | Florian Bruhin | |
2022-06-13 | Update changelog | Florian Bruhin | |
2022-06-13 | Minor fixes | Florian Bruhin | |
2022-06-13 | Merge remote-tracking branch 'origin/pr/7096' | Florian Bruhin | |
2022-06-13 | Update changelog | Florian Bruhin | |
2022-06-13 | Merge remote-tracking branch 'origin/pr/7124' | Florian Bruhin | |
2022-06-13 | Update changelog | Florian Bruhin | |
2022-06-13 | Merge remote-tracking branch 'origin/pr/7196' | Florian Bruhin | |
2022-06-13 | Update changelog | Florian Bruhin | |
2022-06-13 | Merge remote-tracking branch 'origin/pr/7168' | Florian Bruhin | |
2022-06-13 | Update changelog URLs | Florian Bruhin | |
2022-06-13 | Merge remote-tracking branch 'origin/update-dependencies' | Florian Bruhin | |
2022-06-13 | Update docs | Jimmy | |
2022-06-13 | Merge pull request #7241 from emanuele6/doc | Jimmy | |
asciidoc2html.py: also install qute://install.html and qute://stacktrace.html | |||
2022-06-13 | Update dependencies | qutebrowser bot | |
2022-06-10 | asciidoc2html.py: also install qute://{install,stacktrace}.html | Emanuele Torre | |
Closes #6900 | |||
2022-06-08 | Simplify callback default | Florian Bruhin | |
2022-06-08 | pylint: Ignore new false-positives | Florian Bruhin | |
2022-06-08 | pylint: Fix new unnecessary-lambda-assignment | Florian Bruhin | |
2022-06-08 | pylint: Remove outdated disables | Florian Bruhin | |
Looks like 2.14 added bad-option-value: https://pylint.pycqa.org/en/latest/whatsnew/2/2.14/full.html locally-enabled is long gone: https://github.com/PyCQA/pylint/issues/2442 and so is bad-continuation: https://github.com/PyCQA/pylint/pull/3571 no-self-use was moved to an extension in this release: https://github.com/PyCQA/pylint/pull/6448 | |||
2022-06-08 | Update changelog URLs | Florian Bruhin | |
2022-06-06 | Update dependencies | qutebrowser bot | |
2022-06-05 | Merge pull request #7224 from rien333/patch-1 | toofar | |
[readability-js] Remove superfluous css Using the GH UI this time because I don't think this needs a changelog entry :crossed_fingers: | |||
2022-06-03 | Remove superfluous css | Rijnder Wever | |
It makes no sense to force text to be white, especially for users that already use a white background. I probably included this line by mistake. | |||
2022-05-31 | Merge pull request #7219 from possibilities/update-docs-for-debian | Florian Bruhin | |
Update docs for debian, include `libasound` | |||
2022-05-31 | Show dependency list for Buster venv installs | Mike Bannister | |
2022-05-31 | Add `libasound-dev` to venv on debian docs | Mike Bannister | |
2022-05-30 | Update changelog | Florian Bruhin | |
2022-05-30 | Respect input.insert_mode.auto_enter for inspector | Florian Bruhin | |
Fixes #7165 | |||
2022-05-30 | Avoid new mypy false-positive | Florian Bruhin | |
2022-05-30 | Update dependencies | qutebrowser bot | |
2022-05-28 | Update changelog | Florian Bruhin | |