| Age | Commit message (Collapse) | Author |
|---|
|
|
|
See https://github.com/actions/runner-images/issues/6002
|
|
See https://github.com/actions/runner-images/issues/5583
|
|
|
|
|
|
Fixes #3580
|
|
Needed for the next commit. Done in both config.py and configfiles.py
for consistency.
|
|
Those commands use the config interface expecting Python objects (via
update_mutables), but we always used the raw user-supplied string as
input.
Thus far, it was very hard to trigger this bug: It would only
trigger with a List or Dict config option, with a value type which does
*not* accept a string type in to_py(). That means:
- List / FlagList / ConfirmQuit / ShellCommand
- Bool / BoolAsk
- Int
- Float
- Dict / Padding
(Notably, Perc, PercOrInt and Regex all *do* accept a string.)
That leaves only a couple of candidates:
- hints.selectors, but that's "no_autoconfig: true"
- bindings.default, ditto
- bindings.commands, but no reason to use :config-dict-* on it,
especially with fixed keys
Therefore, this got only uncovered now, after adding
content.javascript.log_message.levels, which is a Dict with FlagList
values.
Note that we still don't have any config definition with an affected
List type, thus currently making it impossible to test the changes for
:config-list-{add,remove}.
Also note the adjusted test_{dict,list}_add_invalid_value tests - they
were just plain wrong. The command functions are never going to be
called by a Python object from the user (only with a str).
Finally, test_list_remove_no_value also needed an adjustment because
the value validation now happens *before* the other validation done
by the command.
|
|
If we only clear existing mutables *after* applying, we get into an
inconsistent state if there was an error in one of the config values:
The improper value lingers around in self._mutables, and then gets
returned when get_mutable_obj() (or update_mutables()) gets called the
next time.
Reproducer:
qutebrowser --debug --temp-basedir \
':config-dict-add content.javascript.log_message.levels example.org bla' \
':later 1000 config-dict-add content.javascript.log_message.levels example.org bla'
Results in:
ERROR: Invalid value 'bla' - expected a value of type list but got str.
ERROR: example.org already exists in content.javascript.log_message - use --replace to overwrite!
Fixes the second part of #7343.
nb: As before, the mutable updating actually gets interrupted by a
failing update, instead of it e.g. collecting all errors but carrying
on. With this change, the remaining updates will thus also be discarded,
but that does not seem to be a problem with how mutables are currently
used. Ideally, we should get rid of the mutable handling entirely
anyways, at least for qutebrowser internal code - see #4344.
|
|
Fixes #7342
|
|
Needed for the next commit.
|
|
|
|
|
|
Configurable via a new content.javascript.log_message setting.
Closes #7173, driven by #7335.
|
|
|
|
|
|
|
|
|
|
Partial revert of faf04f3791e533b5b6d69282e4bf063032eca419
|
|
|
|
Update dependencies
|
|
https://github.com/PyCQA/flake8/issues/325
https://github.com/savoirfairelinux/flake8-copyright/pull/9
https://github.com/xZise/flake8-future-import/issues/25
https://github.com/aleGpereira/flake8-mock/issues/10
|
|
|
|
Came through with 0.961 -> 0.971.
Not entirely sure why what change caused them not to be needed but oh
well.
|
|
|
|
Use pytest-bdd:master again in bleeding-edge CI runs
|
|
https://github.com/pytest-dev/pytest-bdd/issues/542 should be fixed now
|
|
Update dependencies
|
|
|
|
See https://github.com/pytest-dev/pytest-bdd/issues/542
Reverts 99f65a13e77b7e756c54801cbd8cb707d5833abc
|
|
Breaks after https://github.com/pytest-dev/pytest-bdd/pull/539
|
|
This reverts commit 70fa33f52d0530f886c1a49d25ba584e48d843cb.
|
|
This reverts commit d1e653115b64d903e2c2014edcd5f5c4414f4805.
|
|
Fixes #7143
|
|
Update dependencies
|
|
|
|
Those seem to fail in weird ways as well...
|
|
Not sure why this is needed out of the sudden...
|
|
Closes #7301
|
|
|
|
|
|
Doesn't seem to actually work.
|
|
|
|
|
|
Update dependencies
|
|
|
|
|
|
|
|
|
|
Fixed #7156: Added zoom keyboard shortcuts to quick start guide
|
