summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2021-03-22wip repo nameciFlorian Bruhin
2021-03-22fixesFlorian Bruhin
2021-03-22Revert "WIP time"Florian Bruhin
This reverts commit 60e3775160b50721ae6d72ce32feae83df494164.
2021-03-22WIP timeFlorian Bruhin
2021-03-22ci: Add bleeding-edge environmentFlorian Bruhin
Closes #6298
2021-03-22Fix test_run_vulture.py with bleeding-edge vultureFlorian Bruhin
See #6298
2021-03-20Update changelogFlorian Bruhin
2021-03-20Improve bindings.key_mappings descriptionFlorian Bruhin
2021-03-20Fix bindings.key_mappings with multiple keysFlorian Bruhin
Otherwise, when e.g. doing "<Meta+Up>": "gg" in bindings.key_mappings, there's a crash like: Traceback (most recent call last): File "/usr/lib/python3.9/site-packages/qutebrowser/keyinput/eventfilter.py", line 105, in eventFilter return handler(typing.cast(QKeyEvent, event)) File "/usr/lib/python3.9/site-packages/qutebrowser/keyinput/eventfilter.py", line 75, in _handle_key_event return man.handle_event(event) File "/usr/lib/python3.9/site-packages/qutebrowser/keyinput/modeman.py", line 462, in handle_event return handler(cast(QKeyEvent, event)) File "/usr/lib/python3.9/site-packages/qutebrowser/keyinput/modeman.py", line 283, in _handle_keypress match = parser.handle(event, dry_run=dry_run) File "/usr/lib/python3.9/site-packages/qutebrowser/keyinput/modeparsers.py", line 105, in handle match = super().handle(e, dry_run=dry_run) File "/usr/lib/python3.9/site-packages/qutebrowser/keyinput/basekeyparser.py", line 309, in handle result = self._match_key_mapping(result.sequence) File "/usr/lib/python3.9/site-packages/qutebrowser/keyinput/basekeyparser.py", line 246, in _match_key_mapping mapped = sequence.with_mappings( File "/usr/lib/python3.9/site-packages/qutebrowser/keyinput/keyutils.py", line 675, in with_mappings assert len(new_seq) == 1 AssertionError While this isn't the intended way to use this setting, we shouldn't crash - and let's just make it work instead of forbidding it.
2021-03-20Update changelogFlorian Bruhin
2021-03-20Merge remote-tracking branch 'origin/pr/6301'Florian Bruhin
2021-03-19Update changelogFlorian Bruhin
2021-03-19Only connect IPC after init has finishedFlorian Bruhin
Otherwise, if there's a fatal error message shown during init, we try to open something via IPC before we're fully initialized. This can e.g. lead to a KeyError for qtnetwork-download-manager: Traceback (most recent call last): File "/usr/lib/python3/dist-packages/qutebrowser/app.py", line 120, in <lambda> process_pos_args(args, cwd=cwd, via_ipc=True, File "/usr/lib/python3/dist-packages/qutebrowser/app.py", line 230, in process_pos_args win_id = mainwindow.get_window(via_ipc, force_window=True) File "/usr/lib/python3/dist-packages/qutebrowser/mainwindow/mainwindow.py", line 89, in get_window window = MainWindow(private=None) File "/usr/lib/python3/dist-packages/qutebrowser/mainwindow/mainwindow.py", line 220, in __init__ self._init_downloadmanager() File "/usr/lib/python3/dist-packages/qutebrowser/mainwindow/mainwindow.py", line 350, in _init_downloadmanager qtnetwork_download_manager = objreg.get('qtnetwork-download-manager') File "/usr/lib/python3/dist-packages/qutebrowser/utils/objreg.py", line 249, in get return reg[name] File "/usr/lib/python3.8/collections/__init__.py", line 1010, in __getitem__ raise KeyError(key) KeyError: 'qtnetwork-download-manager'
2021-03-19Handle OSError in brave adblockFlorian Bruhin
2021-03-19Fix lintFlorian Bruhin
2021-03-19Make certificate error message clearerFlorian Bruhin
2021-03-19Update changelogFlorian Bruhin
2021-03-19Add content.tls.certificate_errors = ask-block-thirdpartyFlorian Bruhin
Fixes #3418
2021-03-19Improve certificate error formattingFlorian Bruhin
2021-03-19Refactor cert error handling to act on single errorsFlorian Bruhin
With QtNetwork, we can get multiple errors at once (reproduced e.g. by using the Superfish certificate on badssl.com). With QtWebEngine, we can only get one error. Things like "is this error coming from a third-party resource" are hard to reason about if there is a list of errors, so change CertificateErrorWrapper so that it's exposed as one single error to the rest of the code.
2021-03-19tests: Don't disable cert verification for QtWebKitFlorian Bruhin
This was added in d385206ea0d3470826242fcda79f1917e8746cda 'to not hang on unexpected SSL errors', but there is no reason those should happen in tests.
2021-03-19Rename ssl_strictFlorian Bruhin
Closes #5156
2021-03-19Merge pull request #6290 from Lembrun/pathlib-/tests/conftest.pyFlorian Bruhin
Pathlib /tests/conftest.py
2021-03-19relative_to instead of is_relativeLembrun
2021-03-19Merge branch 'master' into pathlib-/tests/conftest.pyLembrun
2021-03-19Added fspath = pathlib.Path(path)Lembrun
2021-03-18Update changelogFlorian Bruhin
2021-03-18Add quirk for krunker.ioFlorian Bruhin
2021-03-18Merge pull request #6250 from Lembrun/pathlib-/unit/javascriptFlorian Bruhin
Pathlib /unit/javascript
2021-03-18Update changelogFlorian Bruhin
2021-03-18Merge branch 'dev-split-parser'Florian Bruhin
2021-03-18Fix lintdev-split-parserFlorian Bruhin
As for the mypy unreachable warning, see: See https://github.com/python/mypy/issues/7214 and https://github.com/python/mypy/issues/8766 Includes cherry-pick of 27ad47825279a39141efd11ec9cc54ff2a872517
2021-03-18Move completion fallback handling out of CommandParserFlorian Bruhin
This makes CompletionParser.parse simpler and makes ParseResult.cmd and .args non-Optional. Them being Optional would mean we would've to either resort to more complex typing with Literal, or to check whether they are really non-None everywhere. Since fallback=True is only used at one point, let's just handle this at the calling site instead. In theory, this changes the behavior when the cmdstr is empty and self._partial_match is set, because we now raise early and self._completion_match isn't called anymore. In practice, I think this shouldn't make a difference anywhere, and tests seem to agree. If cmdstr is empty and self._partial_match is False, the behavior should be the same, because objects.commands[''] will raise KeyError.
2021-03-18Fix lintFlorian Bruhin
2021-03-18Fix copy-paste issueFlorian Bruhin
2021-03-18Restore config access in commands.parserFlorian Bruhin
See https://github.com/qutebrowser/qutebrowser/pull/5967#issuecomment-791373157 but no issues with circular imports here, from what I can see...
2021-03-18Merge branch 'master' into dev-split-parserFlorian Bruhin
2021-03-18Make sure QtWebEngine is imported earlyFlorian Bruhin
We need to import the module before a QApplication is created, so that it can set everything up properly. This needs to happen even with the QtWebKit backend configured, so that a proper error can be printed later in backendproblem.py if QtWebKit is unavailable. For QtWebEngine, this is done implicitly in qtargs.py before getting QtWebEngine arguments. For QtWebKit, this used to be done implicitly via version.py importing webenginesettings, but that's not the case anymore since fb0154ae26b09accc08c9ab7fa7cbcbe9fe2578c. Either way, it's better to be explicit about this.
2021-03-18Only run test_flatpak_runtimedir on LinuxFlorian Bruhin
Paths are different on macOS/Windows
2021-03-18Fix test_flatpak_runtimedirFlorian Bruhin
2021-03-18Fix test_no_webengine_vailableFlorian Bruhin
2021-03-18Add a test for flatpak runtime dirFlorian Bruhin
See #6300
2021-03-18pylint: Disable pointless-statement in testsFlorian Bruhin
2021-03-18Rename version.is_sandboxed() to is_flatpak()Florian Bruhin
2021-03-18Import webenginesettings lazily in versionFlorian Bruhin
2021-03-18Use correct runtime path for FlatpakFlorian Bruhin
See #6300 (cherry picked from commit 9f67a763ef86805f0981f037ccd2fb5cb0e84b88)
2021-03-18Update changelogFlorian Bruhin
2021-03-18Try to recover from CompletionMetaInfo with unexpected structureFlorian Bruhin
Fixes #6302
2021-03-18qute-pass userscript: Add -o flag to gopass otp invocation so the metadata ↵s3lph
arount the OTP token is omitted
2021-03-17Drop libgl workaround entirelyFlorian Bruhin
7apu2bq3rhoylwmucxizk54afw5jyda7pho4j5zdcqpwkufke7zdzwad.onion