diff options
Diffstat (limited to 'tests/unit/javascript/test_js_execution.py')
| -rw-r--r-- | tests/unit/javascript/test_js_execution.py | 22 |
1 files changed, 7 insertions, 15 deletions
diff --git a/tests/unit/javascript/test_js_execution.py b/tests/unit/javascript/test_js_execution.py index 8a21d415a..e4d0f8327 100644 --- a/tests/unit/javascript/test_js_execution.py +++ b/tests/unit/javascript/test_js_execution.py @@ -24,15 +24,13 @@ import pytest +from qutebrowser.qt import webkit, webenginecore @pytest.mark.parametrize('js_enabled, expected', [(True, 2.0), (False, None)]) def test_simple_js_webkit(webview, js_enabled, expected): """With QtWebKit, evaluateJavaScript works when JS is on.""" - # If we get there (because of the webview fixture) we can be certain - # QtWebKit is available - from qutebrowser.qt.webkit import QWebSettings - webview.settings().setAttribute(QWebSettings.WebAttribute.JavascriptEnabled, js_enabled) + webview.settings().setAttribute(webkit.QWebSettings.WebAttribute.JavascriptEnabled, js_enabled) result = webview.page().mainFrame().evaluateJavaScript('1 + 1') assert result == expected @@ -40,10 +38,7 @@ def test_simple_js_webkit(webview, js_enabled, expected): @pytest.mark.parametrize('js_enabled, expected', [(True, 2.0), (False, 2.0)]) def test_element_js_webkit(webview, js_enabled, expected): """With QtWebKit, evaluateJavaScript on an element works with JS off.""" - # If we get there (because of the webview fixture) we can be certain - # QtWebKit is available - from qutebrowser.qt.webkit import QWebSettings - webview.settings().setAttribute(QWebSettings.WebAttribute.JavascriptEnabled, js_enabled) + webview.settings().setAttribute(webkit.QWebSettings.WebAttribute.JavascriptEnabled, js_enabled) elem = webview.page().mainFrame().documentElement() result = elem.evaluateJavaScript('1 + 1') assert result == expected @@ -64,16 +59,13 @@ def test_element_js_webkit(webview, js_enabled, expected): def test_simple_js_webengine(qtbot, webengineview, qapp, js_enabled, world, expected): """With QtWebEngine, runJavaScript works even when JS is off.""" - # If we get there (because of the webengineview fixture) we can be certain - # QtWebEngine is available - from qutebrowser.qt.webenginecore import QWebEngineSettings, QWebEngineScript - assert world in [QWebEngineScript.ScriptWorldId.MainWorld, - QWebEngineScript.ScriptWorldId.ApplicationWorld, - QWebEngineScript.ScriptWorldId.UserWorld] + assert world in [webenginecore.QWebEngineScript.ScriptWorldId.MainWorld, + webenginecore.QWebEngineScript.ScriptWorldId.ApplicationWorld, + webenginecore.QWebEngineScript.ScriptWorldId.UserWorld] settings = webengineview.settings() - settings.setAttribute(QWebEngineSettings.WebAttribute.JavascriptEnabled, js_enabled) + settings.setAttribute(webenginecore.QWebEngineSettings.WebAttribute.JavascriptEnabled, js_enabled) qapp.processEvents() page = webengineview.page() |