summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
-rwxr-xr-xscripts/dev/build_release.py22
1 files changed, 13 insertions, 9 deletions
diff --git a/scripts/dev/build_release.py b/scripts/dev/build_release.py
index 5c2c5f168..27d7b04b8 100755
--- a/scripts/dev/build_release.py
+++ b/scripts/dev/build_release.py
@@ -149,15 +149,19 @@ def build_osx():
os.rename('qutebrowser.dmg', dmg_name)
utils.print_title("Running smoke test")
- with tempfile.TemporaryDirectory() as tmpdir:
- subprocess.check_call(['hdiutil', 'attach', dmg_name,
- '-mountpoint', tmpdir])
- try:
- binary = os.path.join(tmpdir, 'qutebrowser.app', 'Contents',
- 'MacOS', 'qutebrowser')
- smoke_test(binary)
- finally:
- subprocess.check_call(['hdiutil', 'detach', tmpdir])
+
+ try:
+ with tempfile.TemporaryDirectory() as tmpdir:
+ subprocess.check_call(['hdiutil', 'attach', dmg_name,
+ '-mountpoint', tmpdir])
+ try:
+ binary = os.path.join(tmpdir, 'qutebrowser.app', 'Contents',
+ 'MacOS', 'qutebrowser')
+ smoke_test(binary)
+ finally:
+ subprocess.call(['hdiutil', 'detach', tmpdir])
+ except PermissionError as e:
+ print("Failed to remove tempdir: {}".format(e))
return [(dmg_name, 'application/x-apple-diskimage', 'OS X .dmg')]