summaryrefslogtreecommitdiff
path: root/tests
diff options
context:
space:
mode:
authorFlorian Bruhin <me@the-compiler.org>2021-03-31 12:15:04 +0200
committerFlorian Bruhin <me@the-compiler.org>2021-03-31 13:10:09 +0200
commitc7657e65cc2eea04aee70d466b436c675707c270 (patch)
tree0c4c3ffb2e28e1dfd47a0bb2ac60c480b3e58456 /tests
parentac9388fb1baba17c99de9d8872c274ab6dd38854 (diff)
downloadqutebrowser-c7657e65cc2eea04aee70d466b436c675707c270.tar.gz
qutebrowser-c7657e65cc2eea04aee70d466b436c675707c270.zip
tests: Skip test_real_chromium_version if guessing too much
Diffstat (limited to 'tests')
-rw-r--r--tests/unit/utils/test_version.py23
1 files changed, 14 insertions, 9 deletions
diff --git a/tests/unit/utils/test_version.py b/tests/unit/utils/test_version.py
index a6c5afe55..d38671e9e 100644
--- a/tests/unit/utils/test_version.py
+++ b/tests/unit/utils/test_version.py
@@ -1008,17 +1008,22 @@ class TestWebEngineVersions:
def test_real_chromium_version(self, qapp):
"""Compare the inferred Chromium version with the real one."""
- if '.dev' in PYQT_VERSION_STR:
- pytest.skip("dev version of PyQt5")
-
- try:
- from PyQt5.QtWebEngine import PYQT_WEBENGINE_VERSION_STR
- except ImportError as e:
- # QtWebKit or QtWebEngine < 5.13
- pytest.skip(str(e))
-
pyqt_webengine_version = version._get_pyqt_webengine_qt_version()
if pyqt_webengine_version is None:
+ if '.dev' in PYQT_VERSION_STR:
+ pytest.skip("dev version of PyQt5")
+
+ try:
+ from PyQt5.QtWebEngine import (
+ PYQT_WEBENGINE_VERSION_STR, PYQT_WEBENGINE_VERSION)
+ except ImportError as e:
+ # QtWebKit or QtWebEngine < 5.13
+ pytest.skip(str(e))
+
+ if PYQT_WEBENGINE_VERSION >= 0x050F02:
+ # Starting with Qt 5.15.2, we can only do bad guessing anyways...
+ pytest.skip("Could be QtWebEngine 5.15.2 or 5.15.3")
+
pyqt_webengine_version = PYQT_WEBENGINE_VERSION_STR
versions = version.WebEngineVersions.from_pyqt(pyqt_webengine_version)