pylint: Handle consider-using-with

3 files changed, 7 insertions, 7 deletions

diff --git a/tests/end2end/data/brave-adblock/generate.py b/tests/end2end/data/brave-adblock/generate.py
index 7a23a21ab..393cda4e7 100644
--- a/tests/end2end/data/brave-adblock/generate.py
+++ b/tests/end2end/data/brave-adblock/generate.py
@@ -53,9 +53,9 @@ def main():
     else:
         request = urllib.request.Request(URL)
         print(f"Downloading {URL} ...")
-        response = urllib.request.urlopen(request)
-        assert response.status == 200
-        data_str = response.read().decode("utf-8")
+        with urllib.request.urlopen(request) as response:
+            assert response.status == 200
+            data_str = response.read().decode("utf-8")
         print(f"Saving to cache file {CACHE_PATH} ...")
         CACHE_PATH.write_text(data_str, encoding="utf-8")
         data = io.StringIO(data_str)
diff --git a/tests/end2end/fixtures/test_webserver.py b/tests/end2end/fixtures/test_webserver.py
index 3c825e5bc..ed0c32ae5 100644
--- a/tests/end2end/fixtures/test_webserver.py
+++ b/tests/end2end/fixtures/test_webserver.py
@@ -37,7 +37,8 @@ def test_server(server, qtbot, path, content, expected):
     with qtbot.wait_signal(server.new_request, timeout=100):
         url = 'http://localhost:{}{}'.format(server.port, path)
         try:
-            response = urllib.request.urlopen(url)
+            with urllib.request.urlopen(url) as response:
+                data = response.read().decode('utf-8')
         except urllib.error.HTTPError as e:
             # "Though being an exception (a subclass of URLError), an HTTPError
             # can also function as a non-exceptional file-like return value
@@ -46,8 +47,6 @@ def test_server(server, qtbot, path, content, expected):
             print(e.read().decode('utf-8'))
             raise
 
-    data = response.read().decode('utf-8')
-
     assert server.get_requests() == [server.ExpectedRequest('GET', path)]
     assert (content in data) == expected
 
diff --git a/tests/unit/utils/test_qtutils.py b/tests/unit/utils/test_qtutils.py
index 2d98feece..d78a132bb 100644
--- a/tests/unit/utils/test_qtutils.py
+++ b/tests/unit/utils/test_qtutils.py
@@ -559,7 +559,8 @@ if test_file is not None:
             qiodev.mode = mode
             # Create empty TESTFN file because the Python tests try to unlink
             # it.after the test.
-            open(test_file.TESTFN, 'w', encoding='utf-8').close()
+            with open(test_file.TESTFN, 'w', encoding='utf-8'):
+                pass
             return qiodev
 
     class PyAutoFileTests(PyIODeviceTestMixin, test_file.AutoFileTests,