diff options
| author | Florian Bruhin <git@the-compiler.org> | 2018-06-07 12:43:05 +0200 |
|---|---|---|
| committer | Florian Bruhin <git@the-compiler.org> | 2018-06-07 13:49:13 +0200 |
| commit | 0e9159e8e87a6bc1e4d880f09f61f084208368d4 (patch) | |
| tree | 5d4827e3218f991a253edcdae24f6a8f27648b83 /tests/unit/browser/webkit/test_webkitelem.py | |
| parent | 3d53d0d2c53869705acd693aca41d1920cf65568 (diff) | |
| download | qutebrowser-0e9159e8e87a6bc1e4d880f09f61f084208368d4.tar.gz qutebrowser-0e9159e8e87a6bc1e4d880f09f61f084208368d4.zip | |
Revert "Fix Qt 5.11 issues with clicking invalid links"
This reverts commit 1956590df84a72c7f9a516e805d01529291fccf8.
Turns out the actual issue wasn't due to *invalid* links - it's with links
which have an unknown scheme.
There's still a change in behavior between Qt 5.10 and 5.11 though: Invalid
links are apparently not passed to acceptNavigationRequest (sometimes?) so we
don't show an error message. Instead, we just load about:blank. However,
Chromium does that too and we can't handle a real click easily, so let's just
ignore that one.
See #3661
Diffstat (limited to 'tests/unit/browser/webkit/test_webkitelem.py')
| -rw-r--r-- | tests/unit/browser/webkit/test_webkitelem.py | 11 |
1 files changed, 0 insertions, 11 deletions
diff --git a/tests/unit/browser/webkit/test_webkitelem.py b/tests/unit/browser/webkit/test_webkitelem.py index d4ad7f008..df3de6310 100644 --- a/tests/unit/browser/webkit/test_webkitelem.py +++ b/tests/unit/browser/webkit/test_webkitelem.py @@ -872,14 +872,3 @@ def test_resolve_url_relative_base(): elem = get_webelem(attributes={'href': 'foo'}) with pytest.raises(ValueError): elem.resolve_url(QUrl('base')) - - -@pytest.mark.parametrize('return_invalid', [True, False]) -def test_resolve_url_invalid(return_invalid): - elem = get_webelem(attributes={'href': 'what://::'}) - baseurl = QUrl('http://www.example.com/') - resolved = elem.resolve_url(baseurl, return_invalid=return_invalid) - if return_invalid: - assert not resolved.isValid() - else: - assert resolved is None |