diff options
author | Florian Bruhin <me@the-compiler.org> | 2021-12-02 17:30:47 +0100 |
---|---|---|
committer | Florian Bruhin <me@the-compiler.org> | 2021-12-02 17:30:47 +0100 |
commit | ed2342a43093a137f5260923eeb5946f4bbb65ee (patch) | |
tree | c27fc570fe52e56000c5d0963a5a8d77de89abd1 /tests/end2end/fixtures/test_webserver.py | |
parent | b9d58034d11674c65dfc5db0d424017cef09ff56 (diff) | |
download | qutebrowser-ed2342a43093a137f5260923eeb5946f4bbb65ee.tar.gz qutebrowser-ed2342a43093a137f5260923eeb5946f4bbb65ee.zip |
pylint: Handle consider-using-with
Diffstat (limited to 'tests/end2end/fixtures/test_webserver.py')
-rw-r--r-- | tests/end2end/fixtures/test_webserver.py | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/tests/end2end/fixtures/test_webserver.py b/tests/end2end/fixtures/test_webserver.py index 3c825e5bc..ed0c32ae5 100644 --- a/tests/end2end/fixtures/test_webserver.py +++ b/tests/end2end/fixtures/test_webserver.py @@ -37,7 +37,8 @@ def test_server(server, qtbot, path, content, expected): with qtbot.wait_signal(server.new_request, timeout=100): url = 'http://localhost:{}{}'.format(server.port, path) try: - response = urllib.request.urlopen(url) + with urllib.request.urlopen(url) as response: + data = response.read().decode('utf-8') except urllib.error.HTTPError as e: # "Though being an exception (a subclass of URLError), an HTTPError # can also function as a non-exceptional file-like return value @@ -46,8 +47,6 @@ def test_server(server, qtbot, path, content, expected): print(e.read().decode('utf-8')) raise - data = response.read().decode('utf-8') - assert server.get_requests() == [server.ExpectedRequest('GET', path)] assert (content in data) == expected |