diff options
| author | toofar <toofar@spalge.com> | 2024-11-16 19:08:56 +1300 |
|---|---|---|
| committer | toofar <toofar@spalge.com> | 2024-11-23 12:15:33 +1300 |
| commit | 66759c7172695b5fe17d3727a4e65b89f079ed90 (patch) | |
| tree | 77079948b39d881b1a75cdd9beb168918636b6de /tests/end2end/features/test_prompts_bdd.py | |
| parent | 427fb47e0ccf9f6fb21e622d60ace6ffa083f324 (diff) | |
| download | qutebrowser-66759c7172695b5fe17d3727a4e65b89f079ed90.tar.gz qutebrowser-66759c7172695b5fe17d3727a4e65b89f079ed90.zip | |
Check pyqt version against hex number, not str
A string comparison of version numbers relies on nice simple version
numbers with approximately the same amount of digits. Who knows what
various systems are running!
Switch to the integer format version number. It's harder to grep for
when dropping a Qt version, but hopefully we have enough "6.8"s around
it to compensate.
Diffstat (limited to 'tests/end2end/features/test_prompts_bdd.py')
| -rw-r--r-- | tests/end2end/features/test_prompts_bdd.py | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/tests/end2end/features/test_prompts_bdd.py b/tests/end2end/features/test_prompts_bdd.py index 2e0cf06dc..26c12fd1a 100644 --- a/tests/end2end/features/test_prompts_bdd.py +++ b/tests/end2end/features/test_prompts_bdd.py @@ -7,7 +7,8 @@ import logging import pytest_bdd as bdd bdd.scenarios('prompts.feature') -from qutebrowser.utils import qtutils, version +from qutebrowser.utils import qtutils +from qutebrowser.qt.webenginecore import PYQT_WEBENGINE_VERSION @bdd.when("I load an SSL page") @@ -47,7 +48,7 @@ def fresh_instance(quteproc): # browser to make it forget previous prompts. if ( qtutils.version_check("6.8", compiled=False) - and version.PYQT_WEBENGINE_VERSION_STR < "6.8.0" + and PYQT_WEBENGINE_VERSION < 0x60800 ): quteproc.terminate() quteproc.start() |