use subprocess run

The usage of subprocess.run is recommended since python 3.5.
Popen, check_call, call and check_output calls were replaced with run.

1 files changed, 6 insertions, 4 deletions

diff --git a/scripts/setupcommon.py b/scripts/setupcommon.py
index 1f85b225f..1832ead86 100644
--- a/scripts/setupcommon.py
+++ b/scripts/setupcommon.py
@@ -51,12 +51,14 @@ def _git_str():
         return None
     try:
         # https://stackoverflow.com/questions/21017300/21017394#21017394
-        commit_hash = subprocess.check_output(
+        commit_hash = subprocess.run(
             ['git', 'describe', '--match=NeVeRmAtCh', '--always', '--dirty'],
-            cwd=BASEDIR).decode('UTF-8').strip()
-        date = subprocess.check_output(
+            cwd=BASEDIR, check=True,
+            stdout=subprocess.PIPE).stdout.decode('UTF-8').strip()
+        date = subprocess.run(
             ['git', 'show', '-s', '--format=%ci', 'HEAD'],
-            cwd=BASEDIR).decode('UTF-8').strip()
+            cwd=BASEDIR, check=True,
+            stdout=subprocess.PIPE).stdout.decode('UTF-8').strip()
         return '{} ({})'.format(commit_hash, date)
     except (subprocess.CalledProcessError, OSError):
         return None