diff options
| author | Florian Bruhin <me@the-compiler.org> | 2021-03-25 15:27:47 +0100 |
|---|---|---|
| committer | Florian Bruhin <me@the-compiler.org> | 2021-03-27 15:30:02 +0100 |
| commit | a60cafec3dfbca0e7f19de114433b97bfb16590b (patch) | |
| tree | fbf25653d4bdbcf9022f76b2f1addf1d9beb6995 /qutebrowser/config/configdata.yml | |
| parent | 82b5f1e7a4b04a5464b10c4c76968be1b5ccbee7 (diff) | |
| download | qutebrowser-a60cafec3dfbca0e7f19de114433b97bfb16590b.tar.gz qutebrowser-a60cafec3dfbca0e7f19de114433b97bfb16590b.zip | |
notifications: Drop Qt 5.13 support in libnotify presenter
Seems to segfault when showing the second notification, despite our
workarounds for Qt 5.14.
Partial stacktrace:
0x00007fffeeacfdb2 in std::_Function_handler<void (std::unique_ptr<QWebEngineNotification, std::default_delete<QWebEngineNotification> >), meth_QWebEngineProfile_setNotificationPresenter::{lambda(std::unique_ptr<QWebEngineNotification, std::default_delete<QWebEngineNotification> >)#1}>::_M_invoke(std::_Any_data const&, std::unique_ptr<QWebEngineNotification, std::default_delete<QWebEngineNotification> >) ()
from .../site-packages/PyQt5/QtWebEngineWidgets.so
0x00007fffee89ff62 in QWebEngineProfilePrivate::showNotification(QSharedPointer<QtWebEngineCore::UserNotificationController>&) ()
from .../site-packages/PyQt5/Qt/lib/libQt5WebEngineWidgets.so.5
0x00007fffe6f45921 in ?? () from .../site-packages/PyQt5/Qt/lib/libQt5WebEngineCore.so.5
It's unlikely this is something we can work around, so let's just
require Qt 5.14 instead.
Diffstat (limited to 'qutebrowser/config/configdata.yml')
| -rw-r--r-- | qutebrowser/config/configdata.yml | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/qutebrowser/config/configdata.yml b/qutebrowser/config/configdata.yml index 0c1b6b2ed..fd488f2b1 100644 --- a/qutebrowser/config/configdata.yml +++ b/qutebrowser/config/configdata.yml @@ -921,12 +921,14 @@ content.notification_presenter: - libnotify: Use a libnotify-compatible presenter if DBus is available, show an error (and fall back to Qt's presenter) otherwise. backend: - QtWebEngine: Qt 5.13 + QtWebEngine: Qt 5.14 QtWebKit: false desc: >- What notification presenter to use for web notifications. - Windows and macOS will always act as if this is set to `qt.` + Note that with Qt 5.14, certain JavaScript features for notifications will not work + with the libnotify notification presenter (the `click` and `close` events, as well + as the `tag` option to replace existing notifications). content.pdfjs: default: false |