Handle install of adblock library during runtime

The _possibly_show_missing_dependency_warning() is only shown if the
"adblock" import is unavailable (i.e. None), thus we assumed that it
must be either not installed or outdated.

However, there's a third possible case: The library wasn't available at
import time, but it *is* available when the setting changed at runtime.
If that's the case, show a warning instead of an AssertionError.

1 files changed, 6 insertions, 2 deletions

diff --git a/qutebrowser/components/braveadblock.py b/qutebrowser/components/braveadblock.py
index 68196255c..a851ff513 100644
--- a/qutebrowser/components/braveadblock.py
+++ b/qutebrowser/components/braveadblock.py
@@ -74,12 +74,16 @@ def _possibly_show_missing_dependency_warning() -> None:
             f"Installed version {adblock_info.get_version()} of the 'adblock' "
             f"dependency is too old. Minimum supported is {adblock_info.min_version}."
         )
-    else:
-        assert not adblock_info.is_installed(), adblock_info
+    elif not adblock_info.is_installed():
         message.warning(
             f"Ad blocking method is set to '{method}' but 'adblock' dependency is not "
             "installed."
         )
+    else:
+        message.warning(
+            "The 'adblock' dependency was unavailable when qutebrowser was started, "
+            "but now seems to be installed. Please :restart qutebrowser to use it."
+        )
 
 
 _RESOURCE_TYPE_STRINGS = {