diff options
| author | Ryan Roden-Corrent <ryan@rcorre.net> | 2020-12-28 18:20:26 -0500 |
|---|---|---|
| committer | Ryan Roden-Corrent <ryan@rcorre.net> | 2020-12-28 18:20:26 -0500 |
| commit | faa4d519301e5399dd7ef0fef344d28845ccd1d4 (patch) | |
| tree | 38695f3b6f1b6b3096f2e1ac663692919002d077 /qutebrowser/completion | |
| parent | 4123cda88a7de7c200072fa78cadfd88b3b450e4 (diff) | |
| download | qutebrowser-faa4d519301e5399dd7ef0fef344d28845ccd1d4.tar.gz qutebrowser-faa4d519301e5399dd7ef0fef344d28845ccd1d4.zip | |
Trim long patterns rather than clearing them.
Fixes #5973.
Diffstat (limited to 'qutebrowser/completion')
| -rw-r--r-- | qutebrowser/completion/models/listcategory.py | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/qutebrowser/completion/models/listcategory.py b/qutebrowser/completion/models/listcategory.py index 307e1ec33..fbe742ddb 100644 --- a/qutebrowser/completion/models/listcategory.py +++ b/qutebrowser/completion/models/listcategory.py @@ -59,13 +59,13 @@ class ListCategory(QSortFilterProxyModel): Args: val: The value to set. """ + if len(val) > 5000: # avoid crash on huge search terms (#5973) + log.completion.warning(f"Trimming {len(val)}-char pattern to 5000") + val = val[:5000] self._pattern = val val = re.sub(r' +', r' ', val) # See #1919 val = re.escape(val) val = val.replace(r'\ ', '.*') - if len(val) > 5000: # avoid crash on huge search terms (#5973) - log.completion.warning(f"Pattern too long ({len(val)})") - val = "^$" rx = QRegularExpression(val, QRegularExpression.CaseInsensitiveOption) qtutils.ensure_valid(rx) self.setFilterRegularExpression(rx) |