diff options
author | Florian Bruhin <me@the-compiler.org> | 2020-07-31 15:16:02 +0200 |
---|---|---|
committer | Florian Bruhin <me@the-compiler.org> | 2020-07-31 15:16:02 +0200 |
commit | ecb189ab8e581232c88e0c9420c7549951b6e716 (patch) | |
tree | 8f71ede778f88d2ecdc32076d36c8ccbfdeb5ba9 /qutebrowser/browser/hints.py | |
parent | 71ab96eb3ce3242a2863403943ce097230800cce (diff) | |
download | qutebrowser-ecb189ab8e581232c88e0c9420c7549951b6e716.tar.gz qutebrowser-ecb189ab8e581232c88e0c9420c7549951b6e716.zip |
Set hint statusbar text after entering hint mode
Otherwise, when entering hint mode from inside another mode, the following will
happen:
- Hint statusbar text gets set
- We enter hint mode
- That leaves e.g. insert mode
- That clears the statusbar
So we end up in hint mode with an empty status bar.
Doesn't seem to be possible to easily write a test for this, as we don't have
enough unit tests for hints and end2end tests can't easily check the statusbar
text :(
Diffstat (limited to 'qutebrowser/browser/hints.py')
-rw-r--r-- | qutebrowser/browser/hints.py | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/qutebrowser/browser/hints.py b/qutebrowser/browser/hints.py index ba4aaac51..daf38a755 100644 --- a/qutebrowser/browser/hints.py +++ b/qutebrowser/browser/hints.py @@ -633,11 +633,12 @@ class HintManager(QObject): keyparser = self._get_keyparser(usertypes.KeyMode.hint) keyparser.update_bindings(strings) + modeman.enter(self._win_id, usertypes.KeyMode.hint, + 'HintManager.start') + message_bridge = objreg.get('message-bridge', scope='window', window=self._win_id) message_bridge.set_text(self._get_text()) - modeman.enter(self._win_id, usertypes.KeyMode.hint, - 'HintManager.start') if self._context.first: self._fire(strings[0]) |