diff options
| author | toofar <toofar@spalge.com> | 2024-04-25 20:33:43 +1200 |
|---|---|---|
| committer | toofar <toofar@spalge.com> | 2024-04-27 13:44:03 +1200 |
| commit | 44a63d9b3a45fd713df525608b25dbe90846766e (patch) | |
| tree | c3988a91d877dcd82de101ba3502596fd0e69003 | |
| parent | a209c86c55a47170f2ad23c5756a4a4e607419dd (diff) | |
| download | qutebrowser-44a63d9b3a45fd713df525608b25dbe90846766e.tar.gz qutebrowser-44a63d9b3a45fd713df525608b25dbe90846766e.zip | |
Wait for evidence of click in e2e before proceeding
I've added a 10ms delay when sending a fake click via QEvents to help with a
timing issue in the prompt e2e tests in Qt6.7. Apparently that throws off the
tight timing of this one test! I guess the `:scroll bottom` comes before the
iframe has been clicked.
I'm a little worried that if we are depending on timing stuff like this we
should be looking at a more thorough solution. Maybe the "and follow" suffix
can trigger it to wait for "Clicked *editable element!"?
Also I can try to reduce the delay in the click, but 10ms is pretty short
already.
| -rw-r--r-- | tests/end2end/features/hints.feature | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/tests/end2end/features/hints.feature b/tests/end2end/features/hints.feature index ddf42132f..b2a549fb5 100644 --- a/tests/end2end/features/hints.feature +++ b/tests/end2end/features/hints.feature @@ -279,6 +279,7 @@ Feature: Using hints When I open data/hints/iframe_scroll.html And I wait for "* simple loaded" in the log And I hint with args "all normal" and follow a + And I wait for "Clicked non-editable element!" in the log And I run :scroll bottom And I hint with args "links normal" and follow a Then "navigation request: url http://localhost:*/data/hello2.txt (current http://localhost:*/data/hints/iframe_scroll.html), type link_clicked, *" should be logged |