diff options
| author | Nicholas42 <gcc@nicholas-schwab.de> | 2021-04-08 23:58:55 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2021-04-08 23:58:55 +0200 |
| commit | bfc28ba6d0fedac3fab746aeecbe1f3ec85d8978 (patch) | |
| tree | 1acf3cd356bbd66acfcdbaf5b9449e6ea4498bc8 | |
| parent | 5e0d6e0d3b5126c6e696d97360d069ea751ef2e8 (diff) | |
| download | qutebrowser-bfc28ba6d0fedac3fab746aeecbe1f3ec85d8978.tar.gz qutebrowser-bfc28ba6d0fedac3fab746aeecbe1f3ec85d8978.zip | |
Apply suggestions from code review
Co-authored-by: Florian Bruhin <me@the-compiler.org>
| -rw-r--r-- | qutebrowser/config/configtypes.py | 5 | ||||
| -rw-r--r-- | qutebrowser/mainwindow/statusbar/bar.py | 6 |
2 files changed, 7 insertions, 4 deletions
diff --git a/qutebrowser/config/configtypes.py b/qutebrowser/config/configtypes.py index 4439cd4f4..c157fba41 100644 --- a/qutebrowser/config/configtypes.py +++ b/qutebrowser/config/configtypes.py @@ -2000,9 +2000,10 @@ class UrlPattern(BaseType): class StatusbarWidget(String): - """A Widget for the status bar. + """A widget for the status bar. - Allows some predefined widgets and custom text-widgets via text:$CONTENT.""" + Allows some predefined widgets and custom text-widgets via text:$CONTENT. + """ def _validate_valid_values(self, value: str) -> None: if value.startswith("text:"): diff --git a/qutebrowser/mainwindow/statusbar/bar.py b/qutebrowser/mainwindow/statusbar/bar.py index 32a899742..19afa5792 100644 --- a/qutebrowser/mainwindow/statusbar/bar.py +++ b/qutebrowser/mainwindow/statusbar/bar.py @@ -200,7 +200,7 @@ class StatusBar(QWidget): self.tabindex = tabindex.TabIndex() self.keystring = keystring.KeyString() self.prog = progress.Progress(self) - self.text_widgets = [] + self._text_widgets = [] self._draw_widgets() config.instance.changed.connect(self._on_config_changed) @@ -252,12 +252,14 @@ class StatusBar(QWidget): self.prog.enabled = True if tab: self.prog.on_tab_changed(tab) - elif segment.startswith('text'): + elif segment.startswith('text:'): cur_widget = textbase.TextBase() self.text_widgets.append(cur_widget) cur_widget.setText(segment.partition(':')[2]) self._hbox.addWidget(cur_widget) cur_widget.show() + else: + raise utils.Unreachable(segment) def _clear_widgets(self): """Clear widgets before redrawing them.""" |