summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorFlorian Bruhin <me@the-compiler.org>2021-03-02 10:04:54 +0100
committerFlorian Bruhin <me@the-compiler.org>2021-03-02 10:04:54 +0100
commit7294840bc5b9987e06e8bbcf709f22dd0b5e70ec (patch)
tree96e8c1168b2e9b7d471f267716bc3e963333cf2e
parent024e7ec38d46b1b1759e34cc660d2b3e4f97de4d (diff)
parentcdb1de638487a2e292ae511a1d2535c0dde12c62 (diff)
downloadqutebrowser-7294840bc5b9987e06e8bbcf709f22dd0b5e70ec.tar.gz
qutebrowser-7294840bc5b9987e06e8bbcf709f22dd0b5e70ec.zip
Merge remote-tracking branch 'origin/pr/6222'
-rw-r--r--qutebrowser/browser/commands.py4
-rw-r--r--tests/end2end/features/sessions.feature5
-rw-r--r--tests/end2end/features/tabs.feature5
3 files changed, 9 insertions, 5 deletions
diff --git a/qutebrowser/browser/commands.py b/qutebrowser/browser/commands.py
index dc0664238..4e8ad8d57 100644
--- a/qutebrowser/browser/commands.py
+++ b/qutebrowser/browser/commands.py
@@ -329,7 +329,9 @@ class CommandDispatcher:
# Explicit count with a tab that doesn't exist.
return
elif curtab.navigation_blocked():
- message.info("Tab is pinned!")
+ message.info("Tab is pinned! Opening in new tab")
+ self._tabbed_browser.tabopen(cur_url)
+
else:
curtab.load_url(cur_url)
diff --git a/tests/end2end/features/sessions.feature b/tests/end2end/features/sessions.feature
index 0f0c015e0..cdf214396 100644
--- a/tests/end2end/features/sessions.feature
+++ b/tests/end2end/features/sessions.feature
@@ -395,9 +395,10 @@ Feature: Saving and loading sessions
And I run :session-load -c pin_session
And I wait until data/numbers/3.txt is loaded
And I run :tab-focus 2
- And I run :open hello world
- Then the message "Tab is pinned!" should be shown
+ And I run :open data/numbers/4.txt
+ Then the message "Tab is pinned! Opening in new tab" should be shown
And the following tabs should be open:
- data/numbers/1.txt
- data/numbers/2.txt (active) (pinned)
+ - data/numbers/4.txt
- data/numbers/3.txt
diff --git a/tests/end2end/features/tabs.feature b/tests/end2end/features/tabs.feature
index ca0efefc4..16d2c4f14 100644
--- a/tests/end2end/features/tabs.feature
+++ b/tests/end2end/features/tabs.feature
@@ -1534,10 +1534,11 @@ Feature: Tab management
Scenario: :tab-pin open url
When I open data/numbers/1.txt
And I run :tab-pin
- And I open data/numbers/2.txt without waiting
- Then the message "Tab is pinned!" should be shown
+ And I open data/numbers/2.txt
+ Then the message "Tab is pinned! Opening in new tab" should be shown
And the following tabs should be open:
- data/numbers/1.txt (active) (pinned)
+ - data/numbers/2.txt
Scenario: :tab-pin open url with tabs.pinned.frozen = false
When I set tabs.pinned.frozen to false