summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorFlorian Bruhin <me@the-compiler.org>2021-03-11 12:51:44 +0100
committerFlorian Bruhin <me@the-compiler.org>2021-03-11 14:17:19 +0100
commita1b14f7b3561c1f8ed34a16c9bebc666df112385 (patch)
tree48756468386615236e67064de1bc9828d450961d
parentb02fd9ef489b4f080fa77cb7f5f951e361b6ad68 (diff)
downloadqutebrowser-a1b14f7b3561c1f8ed34a16c9bebc666df112385.tar.gz
qutebrowser-a1b14f7b3561c1f8ed34a16c9bebc666df112385.zip
Handle PyQt(WebEngine)-Qt5 packages
-rw-r--r--qutebrowser/utils/version.py15
1 files changed, 10 insertions, 5 deletions
diff --git a/qutebrowser/utils/version.py b/qutebrowser/utils/version.py
index e61d18448..a561da3be 100644
--- a/qutebrowser/utils/version.py
+++ b/qutebrowser/utils/version.py
@@ -492,6 +492,9 @@ def _get_pyqt_webengine_qt_version() -> Optional[str]:
https://www.riverbankcomputing.com/pipermail/pyqt/2021-February/043591.html
https://www.riverbankcomputing.com/pipermail/pyqt/2021-February/043638.html
+ PyQtWebEngine 5.15.4 renamed it to PyQtWebEngine-Qt5...:
+ https://www.riverbankcomputing.com/pipermail/pyqt/2021-March/043699.html
+
Here, we try to use importlib.metadata or its backport (optional dependency) to
figure out that version number. If PyQtWebEngine is installed via pip, this will
give us an accurate answer.
@@ -505,11 +508,13 @@ def _get_pyqt_webengine_qt_version() -> Optional[str]:
log.misc.debug("Neither importlib.metadata nor backport available")
return None
- try:
- return importlib_metadata.version('PyQtWebEngine-Qt')
- except importlib_metadata.PackageNotFoundError:
- log.misc.debug("PyQtWebEngine-Qt not found")
- return None
+ for suffix in ['Qt5', 'Qt']:
+ try:
+ return importlib_metadata.version(f'PyQtWebEngine-{suffix}')
+ except importlib_metadata.PackageNotFoundError:
+ log.misc.debug(f"PyQtWebEngine-{suffix} not found")
+
+ return None
@dataclasses.dataclass