summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorFlorian Bruhin <me@the-compiler.org>2021-01-27 14:08:49 +0100
committerFlorian Bruhin <me@the-compiler.org>2021-01-27 14:08:49 +0100
commit6d8e21d366b2a7c00dd6b4f7bf3b8a25cf7c971f (patch)
treedb4ef88543f3e446a395ebce7116ff245a13cedf
parent7d8fd507924309227ebb6c11c3d32cb0b013d238 (diff)
downloadqutebrowser-6d8e21d366b2a7c00dd6b4f7bf3b8a25cf7c971f.tar.gz
qutebrowser-6d8e21d366b2a7c00dd6b4f7bf3b8a25cf7c971f.zip
tests: Skip "Using JS after window.open" on Windows
Seems to be flaky pretty consistantly there... See #5390
-rw-r--r--tests/end2end/conftest.py5
-rw-r--r--tests/end2end/features/javascript.feature2
2 files changed, 6 insertions, 1 deletions
diff --git a/tests/end2end/conftest.py b/tests/end2end/conftest.py
index aea08c5db..879ebc6de 100644
--- a/tests/end2end/conftest.py
+++ b/tests/end2end/conftest.py
@@ -167,6 +167,11 @@ def pytest_collection_modifyitems(config, items):
'Skipped with QtWebKit if PDF image plugin is available',
pytest.mark.skipif,
not config.webengine and qpdf_image_plugin.exists()),
+ ('windows_skip',
+ 'Skipped on Windows',
+ pytest.mark.skipif,
+ utils.is_windows),
+
]
for item in items:
diff --git a/tests/end2end/features/javascript.feature b/tests/end2end/features/javascript.feature
index 95d435267..3666d609d 100644
--- a/tests/end2end/features/javascript.feature
+++ b/tests/end2end/features/javascript.feature
@@ -167,7 +167,7 @@ Feature: Javascript stuff
Then "Showing error page for* 500" should be logged
And "Load error: *500" should be logged
- @flaky
+ @flaky @windows_skip
Scenario: Using JS after window.open
When I open data/hello.txt
And I set content.javascript.can_open_tabs_automatically to true