diff options
| author | Florian Bruhin <me@the-compiler.org> | 2019-09-19 21:23:36 +0200 |
|---|---|---|
| committer | Florian Bruhin <me@the-compiler.org> | 2019-09-19 21:23:36 +0200 |
| commit | 7370f61f5aac746743dafab538c37f109a09ef17 (patch) | |
| tree | 98cd63fc6581e06d39c6d8be86c799829d3272b3 | |
| parent | a06887b17930ede6137a96f9340bf770245ce490 (diff) | |
| download | qutebrowser-7370f61f5aac746743dafab538c37f109a09ef17.tar.gz qutebrowser-7370f61f5aac746743dafab538c37f109a09ef17.zip | |
version: Add support for PYQT_WEBENGINE_VERSION_STR
PyQtWebEngine 5.13.2 (or 5.14?) will add this.
| -rw-r--r-- | qutebrowser/utils/version.py | 1 | ||||
| -rw-r--r-- | tests/unit/utils/test_version.py | 7 |
2 files changed, 6 insertions, 2 deletions
diff --git a/qutebrowser/utils/version.py b/qutebrowser/utils/version.py index bee3934e6..3d784dd91 100644 --- a/qutebrowser/utils/version.py +++ b/qutebrowser/utils/version.py @@ -217,6 +217,7 @@ def _module_versions(): ('cssutils', ['__version__']), ('attr', ['__version__']), ('PyQt5.QtWebEngineWidgets', []), + ('PyQt5.QtWebEngine', ['PYQT_WEBENGINE_VERSION_STR']), ('PyQt5.QtWebKitWidgets', []), ]) for modname, attributes in modules.items(): diff --git a/tests/unit/utils/test_version.py b/tests/unit/utils/test_version.py index d3fec166d..89dcc4bf8 100644 --- a/tests/unit/utils/test_version.py +++ b/tests/unit/utils/test_version.py @@ -539,10 +539,13 @@ class ImportFake: ('cssutils', True), ('attr', True), ('PyQt5.QtWebEngineWidgets', True), + ('PyQt5.QtWebEngine', True), ('PyQt5.QtWebKitWidgets', True), ]) - self.no_version_attribute = ['sip', 'PyQt5.QtWebEngineWidgets', - 'PyQt5.QtWebKitWidgets'] + self.no_version_attribute = ['sip', + 'PyQt5.QtWebEngineWidgets', + 'PyQt5.QtWebKitWidgets', + 'PyQt5.QtWebEngine'] self.version_attribute = '__version__' self.version = '1.2.3' self._real_import = builtins.__import__ |