Make TabbedBrowser signals private if possible

1 files changed, 20 insertions, 20 deletions

diff --git a/qutebrowser/mainwindow/tabbedbrowser.py b/qutebrowser/mainwindow/tabbedbrowser.py
index 023e6c2ab..9f697f498 100644
--- a/qutebrowser/mainwindow/tabbedbrowser.py
+++ b/qutebrowser/mainwindow/tabbedbrowser.py
@@ -122,7 +122,7 @@ class TabbedBrowser(QWidget):
         self.shutting_down = False
         self.widget.tabCloseRequested.connect(self.on_tab_close_requested)
         self.widget.new_tab_requested.connect(self.tabopen)
-        self.widget.currentChanged.connect(self.on_current_changed)
+        self.widget.currentChanged.connect(self._on_current_changed)
         self.cur_fullscreen_requested.connect(self.widget.tabBar().maybe_hide)
         self.widget.setSizePolicy(QSizePolicy.Expanding, QSizePolicy.Expanding)
 
@@ -242,24 +242,24 @@ class TabbedBrowser(QWidget):
         tab.caret.selection_toggled.connect(
             self._filter.create(self.cur_caret_selection_toggled, tab))
         # misc
-        tab.scroller.perc_changed.connect(self.on_scroll_pos_changed)
+        tab.scroller.perc_changed.connect(self._on_scroll_pos_changed)
         tab.scroller.before_jump_requested.connect(lambda: self.set_mark("'"))
         tab.url_changed.connect(
-            functools.partial(self.on_url_changed, tab))
+            functools.partial(self._on_url_changed, tab))
         tab.title_changed.connect(
-            functools.partial(self.on_title_changed, tab))
+            functools.partial(self._on_title_changed, tab))
         tab.icon_changed.connect(
-            functools.partial(self.on_icon_changed, tab))
+            functools.partial(self._on_icon_changed, tab))
         tab.load_progress.connect(
-            functools.partial(self.on_load_progress, tab))
+            functools.partial(self._on_load_progress, tab))
         tab.load_finished.connect(
-            functools.partial(self.on_load_finished, tab))
+            functools.partial(self._on_load_finished, tab))
         tab.load_started.connect(
-            functools.partial(self.on_load_started, tab))
+            functools.partial(self._on_load_started, tab))
         tab.load_status_changed.connect(
-            functools.partial(self.on_load_status_changed, tab))
+            functools.partial(self._on_load_status_changed, tab))
         tab.window_close_requested.connect(
-            functools.partial(self.on_window_close_requested, tab))
+            functools.partial(self._on_window_close_requested, tab))
         tab.renderer_process_terminated.connect(
             functools.partial(self._on_renderer_process_terminated, tab))
         tab.audio.muted_changed.connect(
@@ -444,7 +444,7 @@ class TabbedBrowser(QWidget):
             tab, False, lambda: self.close_tab(tab))
 
     @pyqtSlot(browsertab.AbstractTab)
-    def on_window_close_requested(self, widget):
+    def _on_window_close_requested(self, widget):
         """Close a tab with a widget given."""
         try:
             self.close_tab(widget)
@@ -585,7 +585,7 @@ class TabbedBrowser(QWidget):
             self.widget.update_tab_favicon(tab)
 
     @pyqtSlot()
-    def on_load_started(self, tab):
+    def _on_load_started(self, tab):
         """Clear icon and update title when a tab started loading.
 
         Args:
@@ -599,7 +599,7 @@ class TabbedBrowser(QWidget):
                 self.widget.window().setWindowIcon(self.default_window_icon)
 
     @pyqtSlot()
-    def on_load_status_changed(self, tab):
+    def _on_load_status_changed(self, tab):
         """Update tab/window titles if the load status changed."""
         try:
             idx = self._tab_index(tab)
@@ -633,7 +633,7 @@ class TabbedBrowser(QWidget):
             log.modes.debug("Ignoring leave_on_load request due to setting.")
 
     @pyqtSlot(browsertab.AbstractTab, str)
-    def on_title_changed(self, tab, text):
+    def _on_title_changed(self, tab, text):
         """Set the title of a tab.
 
         Slot for the title_changed signal of any tab.
@@ -657,7 +657,7 @@ class TabbedBrowser(QWidget):
             self._update_window_title()
 
     @pyqtSlot(browsertab.AbstractTab, QUrl)
-    def on_url_changed(self, tab, url):
+    def _on_url_changed(self, tab, url):
         """Set the new URL as title if there's no title yet.
 
         Args:
@@ -674,7 +674,7 @@ class TabbedBrowser(QWidget):
             self.widget.set_page_title(idx, url.toDisplayString())
 
     @pyqtSlot(browsertab.AbstractTab, QIcon)
-    def on_icon_changed(self, tab, icon):
+    def _on_icon_changed(self, tab, icon):
         """Set the icon of a tab.
 
         Slot for the iconChanged signal of any tab.
@@ -717,7 +717,7 @@ class TabbedBrowser(QWidget):
             widget.data.input_mode = usertypes.KeyMode.normal
 
     @pyqtSlot(int)
-    def on_current_changed(self, idx):
+    def _on_current_changed(self, idx):
         """Set last-focused-tab and leave hinting mode when focus changed."""
         mode_on_change = config.val.tabs.mode_on_change
         if idx == -1 or self.shutting_down:
@@ -761,7 +761,7 @@ class TabbedBrowser(QWidget):
         """Set focus when the commandline closes."""
         log.modes.debug("Commandline closed, focusing {!r}".format(self))
 
-    def on_load_progress(self, tab, perc):
+    def _on_load_progress(self, tab, perc):
         """Adjust tab indicator on load progress."""
         try:
             idx = self._tab_index(tab)
@@ -777,7 +777,7 @@ class TabbedBrowser(QWidget):
         if idx == self.widget.currentIndex():
             self._update_window_title()
 
-    def on_load_finished(self, tab, ok):
+    def _on_load_finished(self, tab, ok):
         """Adjust tab indicator when loading finished."""
         try:
             idx = self._tab_index(tab)
@@ -796,7 +796,7 @@ class TabbedBrowser(QWidget):
             tab.private_api.handle_auto_insert_mode(ok)
 
     @pyqtSlot()
-    def on_scroll_pos_changed(self):
+    def _on_scroll_pos_changed(self):
         """Update tab and window title when scroll position changed."""
         idx = self.widget.currentIndex()
         if idx == -1: