summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorFlorian Bruhin <me@the-compiler.org>2019-02-21 14:11:30 +0100
committerFlorian Bruhin <me@the-compiler.org>2019-02-21 14:11:30 +0100
commitb10d84f31a511dd8e1a36019b60235f6a7f286ed (patch)
treed7305187049b9eb0344c68176fb212cbee0c66bc
parent03e7fdf507bd5f2750f51c0c412524c884f645e7 (diff)
downloadqutebrowser-b10d84f31a511dd8e1a36019b60235f6a7f286ed.tar.gz
qutebrowser-b10d84f31a511dd8e1a36019b60235f6a7f286ed.zip
Warn when combining Qt 5.12 with older Qt
Fixes #4581
-rw-r--r--qutebrowser/misc/earlyinit.py10
1 files changed, 9 insertions, 1 deletions
diff --git a/qutebrowser/misc/earlyinit.py b/qutebrowser/misc/earlyinit.py
index a2db81764..61ae1dbfc 100644
--- a/qutebrowser/misc/earlyinit.py
+++ b/qutebrowser/misc/earlyinit.py
@@ -173,8 +173,10 @@ def check_qt_version():
PYQT_VERSION_STR)
from pkg_resources import parse_version
from qutebrowser.utils import log
+ parsed_qversion = parse_version(qVersion())
+
if (QT_VERSION < 0x050701 or PYQT_VERSION < 0x050700 or
- parse_version(qVersion()) < parse_version('5.7.1')):
+ parsed_qversion < parse_version('5.7.1')):
text = ("Fatal error: Qt >= 5.7.1 and PyQt >= 5.7 are required, "
"but Qt {} / PyQt {} is installed.".format(qt_version(),
PYQT_VERSION_STR))
@@ -184,6 +186,12 @@ def check_qt_version():
log.init.warning("Running qutebrowser with Qt 5.8 is untested and "
"unsupported!")
+ if (parsed_qversion >= parse_version('5.12') and
+ (PYQT_VERSION < 0x050c00 or QT_VERSION < 0x050c00)):
+ log.init.warning("Combining PyQt {} with Qt {} is unsupported! Ensure "
+ "all versions are newer than 5.12 to avoid potential "
+ "issues.".format(PYQT_VERSION_STR, qt_version()))
+
def check_ssl_support():
"""Check if SSL support is available."""