diff options
| author | user202729 <25191436+user202729@users.noreply.github.com> | 2019-05-05 10:47:53 +0700 |
|---|---|---|
| committer | Florian Bruhin <me@the-compiler.org> | 2019-05-06 09:01:02 +0200 |
| commit | 54641dc7e019c2f843b09d89c988b1cc7c18a4f1 (patch) | |
| tree | d61db0bb2dd2da344945cc283bbd38ad64005579 | |
| parent | 2afb3929e91e87569cfae6db410da66276b7f581 (diff) | |
| download | qutebrowser-54641dc7e019c2f843b09d89c988b1cc7c18a4f1.tar.gz qutebrowser-54641dc7e019c2f843b09d89c988b1cc7c18a4f1.zip | |
Fixes crash in #1249
See https://github.com/qutebrowser/qutebrowser/issues/1249#issuecomment-446266469 for details.
| -rw-r--r-- | qutebrowser/mainwindow/prompt.py | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/qutebrowser/mainwindow/prompt.py b/qutebrowser/mainwindow/prompt.py index d7d34a0cf..9fd3da8dd 100644 --- a/qutebrowser/mainwindow/prompt.py +++ b/qutebrowser/mainwindow/prompt.py @@ -36,7 +36,6 @@ from qutebrowser.config import config from qutebrowser.utils import usertypes, log, utils, qtutils, objreg, message from qutebrowser.keyinput import modeman from qutebrowser.api import cmdutils -from qutebrowser.qt import sip prompt_queue = None @@ -118,10 +117,11 @@ class PromptQueue(QObject): log.prompt.debug("Popping from queue {}".format(self._queue)) if self._queue: question = self._queue.popleft() - if not sip.isdeleted(question): - # the question could already be deleted, e.g. by a cancelled + if not question.is_aborted: + # the question could already be aborted, e.g. by a cancelled # download. See - # https://github.com/qutebrowser/qutebrowser/issues/415 + # https://github.com/qutebrowser/qutebrowser/issues/415 and + # https://github.com/qutebrowser/qutebrowser/issues/1249 self.ask_question(question, blocking=False) def shutdown(self): |