diff options
| author | Florian Bruhin <me@the-compiler.org> | 2018-10-26 10:13:37 +0200 |
|---|---|---|
| committer | Florian Bruhin <me@the-compiler.org> | 2018-10-26 10:19:23 +0200 |
| commit | 6158634c4cdc0fc7a8f433ea5ff58039a7f71273 (patch) | |
| tree | acd4cfd3306d2f903b483773409a47f8b440a72f | |
| parent | c7a21b37e331cf3f6414e7fdfbbc3e4b4f9f621d (diff) | |
| download | qutebrowser-6158634c4cdc0fc7a8f433ea5ff58039a7f71273.tar.gz qutebrowser-6158634c4cdc0fc7a8f433ea5ff58039a7f71273.zip | |
Set content.cookies.accept to all by default
Setting it to no-3rdparty is a nice idea from a "privacy by default"
perspective, but it also breaks various pages.
In particular, due to what's probably a Qt bug, it breaks the new GMail:
https://bugreports.qt.io/browse/QTBUG-71393
Let's be in line with what other browsers by default here.
Fixes #4281
(cherry picked from commit a5dba340887fb325d1937d26c07cdcbb6cf27ab1)
| -rw-r--r-- | doc/help/settings.asciidoc | 4 | ||||
| -rw-r--r-- | qutebrowser/config/configdata.yml | 5 |
2 files changed, 5 insertions, 4 deletions
diff --git a/doc/help/settings.asciidoc b/doc/help/settings.asciidoc index 60257de62..269235ba4 100644 --- a/doc/help/settings.asciidoc +++ b/doc/help/settings.asciidoc @@ -1566,11 +1566,11 @@ Type: <<types,String>> Valid values: * +all+: Accept all cookies. - * +no-3rdparty+: Accept cookies from the same origin only. + * +no-3rdparty+: Accept cookies from the same origin only. This is known to break some sites, such as GMail. * +no-unknown-3rdparty+: Accept cookies from the same origin only, unless a cookie is already set for the domain. On QtWebEngine, this is the same as no-3rdparty. * +never+: Don't accept cookies at all. -Default: +pass:[no-3rdparty]+ +Default: +pass:[all]+ On QtWebEngine, this setting requires Qt 5.11 or newer. diff --git a/qutebrowser/config/configdata.yml b/qutebrowser/config/configdata.yml index 34b2d4923..7781a3430 100644 --- a/qutebrowser/config/configdata.yml +++ b/qutebrowser/config/configdata.yml @@ -327,7 +327,7 @@ content.cache.appcache: ask the application cache for the contents, before hitting the network. content.cookies.accept: - default: no-3rdparty + default: all backend: QtWebKit: true QtWebEngine: Qt 5.11 @@ -335,7 +335,8 @@ content.cookies.accept: name: String valid_values: - all: "Accept all cookies." - - no-3rdparty: "Accept cookies from the same origin only." + - no-3rdparty: "Accept cookies from the same origin only. This is known + to break some sites, such as GMail." - no-unknown-3rdparty: "Accept cookies from the same origin only, unless a cookie is already set for the domain. On QtWebEngine, this is the same as no-3rdparty." |