diff options
| author | Jimmy <jimmy@spalge.com> | 2018-06-26 14:45:38 +1200 |
|---|---|---|
| committer | Jimmy <jimmy@spalge.com> | 2018-06-26 16:42:31 +1200 |
| commit | ee2c7658592d65030c76178267d04ac63213b2d9 (patch) | |
| tree | 60087f618f53fb5da78823da26730c1d6c2941e2 | |
| parent | 6f1232e621355f8940993dc5c1bed4252b113aef (diff) | |
| download | qutebrowser-ee2c7658592d65030c76178267d04ac63213b2d9.tar.gz qutebrowser-ee2c7658592d65030c76178267d04ac63213b2d9.zip | |
greasemonkey: check _widget is not deleted
Just for good luck.
No crash has been reported here but it is a common pattern for functions
called from signals.
| -rw-r--r-- | qutebrowser/browser/webengine/webenginetab.py | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/qutebrowser/browser/webengine/webenginetab.py b/qutebrowser/browser/webengine/webenginetab.py index d3d497ec7..8734a4b04 100644 --- a/qutebrowser/browser/webengine/webenginetab.py +++ b/qutebrowser/browser/webengine/webenginetab.py @@ -908,6 +908,9 @@ class _WebEngineScripts(QObject): remove_first: Whether to remove all previously injected scripts before adding these ones. """ + if sip.isdeleted(self._widget): + return + # Since we are inserting scripts into a per-tab collection, # rather than just injecting scripts on page load, we need to # make sure we replace existing scripts, not just add new ones. |