diff options
| author | lufte <javierayres@gmail.com> | 2018-08-17 01:00:32 -0300 |
|---|---|---|
| committer | Jay Kamat <jaygkamat@gmail.com> | 2018-08-18 13:45:59 -0700 |
| commit | 88e2ed0056257fc5d6e873cceeae8ea8eb7e3315 (patch) | |
| tree | 6fa1efe9764abb01933ff8c1b60dca1177f57b56 | |
| parent | ed52384a19ac607dd2e5c85943fe184c7c83f0f2 (diff) | |
| download | qutebrowser-88e2ed0056257fc5d6e873cceeae8ea8eb7e3315.tar.gz qutebrowser-88e2ed0056257fc5d6e873cceeae8ea8eb7e3315.zip | |
Some memory improvements with generators
(cherry picked from commit fd70d6d2d8d516ad424211d0fb7b89caee771009)
| -rw-r--r-- | qutebrowser/utils/log.py | 8 |
1 files changed, 3 insertions, 5 deletions
diff --git a/qutebrowser/utils/log.py b/qutebrowser/utils/log.py index ef8aa2ae5..f14b6be1e 100644 --- a/qutebrowser/utils/log.py +++ b/qutebrowser/utils/log.py @@ -569,16 +569,14 @@ class RAMHandler(logging.Handler): https://github.com/qutebrowser/qutebrowser/issues/34 """ minlevel = LOG_LEVELS.get(level.upper(), VDEBUG_LEVEL) - lines = [] fmt = self.html_formatter.format if html else self.format self.acquire() try: - records = list(self._data) + lines = list(fmt(record) + for record in self._data + if record.levelno >= minlevel) finally: self.release() - for record in records: - if record.levelno >= minlevel: - lines.append(fmt(record)) return '\n'.join(lines) def change_log_capacity(self, capacity): |