diff options
| author | Florian Bruhin <git@the-compiler.org> | 2018-07-28 09:18:50 +0200 |
|---|---|---|
| committer | Florian Bruhin <git@the-compiler.org> | 2018-08-15 10:55:18 +0200 |
| commit | 76a96093c795faacd424eec5e5134e07fe416397 (patch) | |
| tree | ddbeeadac7d98622741e7135a8e08aa54c16793d | |
| parent | c0aa17b97e81ff3a00b7fe0d7b6dc31b876f84ad (diff) | |
| download | qutebrowser-76a96093c795faacd424eec5e5134e07fe416397.tar.gz qutebrowser-76a96093c795faacd424eec5e5134e07fe416397.zip | |
Ignore invalid URLs in acceptNavigationRequest
(cherry picked from commit 7ac7ccc2967d19cae332e7082e380e7df27d1e75)
| -rw-r--r-- | qutebrowser/browser/webengine/webview.py | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/qutebrowser/browser/webengine/webview.py b/qutebrowser/browser/webengine/webview.py index b10cc5f9a..784bc57d6 100644 --- a/qutebrowser/browser/webengine/webview.py +++ b/qutebrowser/browser/webengine/webview.py @@ -242,6 +242,14 @@ class WebEnginePage(QWebEnginePage): typ: QWebEnginePage.NavigationType, is_main_frame: bool): """Override acceptNavigationRequest to forward it to the tab API.""" + if not url.isValid(): + # WORKAROUND for missing IDNA 2008 support in QUrl + # see https://bugreports.qt.io/browse/QTBUG-60364 + log.webview.debug("Ignoring invalid URL {} in " + "acceptNavigationRequest: {}".format( + url.toDisplayString(), url.errorString())) + return True + type_map = { QWebEnginePage.NavigationTypeLinkClicked: usertypes.NavigationRequest.Type.link_clicked, |